diff options
| -rw-r--r-- | cryptography/hazmat/backends/openssl/backend.py | 5 | ||||
| -rw-r--r-- | cryptography/hazmat/primitives/interfaces.py | 12 | ||||
| -rw-r--r-- | tests/hazmat/primitives/test_ec.py | 22 |
3 files changed, 39 insertions, 0 deletions
diff --git a/cryptography/hazmat/backends/openssl/backend.py b/cryptography/hazmat/backends/openssl/backend.py index 567f1648..bb1a3f3d 100644 --- a/cryptography/hazmat/backends/openssl/backend.py +++ b/cryptography/hazmat/backends/openssl/backend.py @@ -984,6 +984,11 @@ class Backend(object): values. """ + if x < 0 or y < 0: + raise ValueError( + "Invalid EC key. Both x and y must be non-negative." + ) + bn_x = self._int_to_bn(x) bn_y = self._int_to_bn(y) diff --git a/cryptography/hazmat/primitives/interfaces.py b/cryptography/hazmat/primitives/interfaces.py index c7ad0cf8..6ae0a4c5 100644 --- a/cryptography/hazmat/primitives/interfaces.py +++ b/cryptography/hazmat/primitives/interfaces.py @@ -287,6 +287,12 @@ class DSAPrivateKey(object): The DSAParameters object associated with this private key. """ + @abc.abstractmethod + def signer(self, signature_algorithm): + """ + Returns an AsymmetricSignatureContext used for signing data. + """ + @six.add_metaclass(abc.ABCMeta) class DSAPrivateKeyWithNumbers(DSAPrivateKey): @@ -311,6 +317,12 @@ class DSAPublicKey(object): The DSAParameters object associated with this public key. """ + @abc.abstractmethod + def verifier(self, signature, signature_algorithm): + """ + Returns an AsymmetricVerificationContext used for signing data. + """ + @six.add_metaclass(abc.ABCMeta) class DSAPublicKeyWithNumbers(DSAPublicKey): diff --git a/tests/hazmat/primitives/test_ec.py b/tests/hazmat/primitives/test_ec.py index 887520de..1b3bb9b3 100644 --- a/tests/hazmat/primitives/test_ec.py +++ b/tests/hazmat/primitives/test_ec.py @@ -274,6 +274,28 @@ class TestECDSAVectors(object): with pytest.raises(ValueError): numbers.private_key(backend) + numbers = ec.EllipticCurvePrivateNumbers( + 357646505660320080863666618182642070958081774038609089496899025506, + ec.EllipticCurvePublicNumbers( + -4725080841032702313157360200834589492768638177232556118553296, + 1120253292479243545483756778742719537373113335231773536789915, + ec.SECP256R1(), + ) + ) + with pytest.raises(ValueError): + numbers.private_key(backend) + + numbers = ec.EllipticCurvePrivateNumbers( + 357646505660320080863666618182642070958081774038609089496899025506, + ec.EllipticCurvePublicNumbers( + 47250808410327023131573602008345894927686381772325561185532964, + -1120253292479243545483756778742719537373113335231773536789915, + ec.SECP256R1(), + ) + ) + with pytest.raises(ValueError): + numbers.private_key(backend) + @pytest.mark.parametrize( "vector", load_vectors_from_file( |