From 93d7737fe3ef26c9b6b09a951826110e452b939d Mon Sep 17 00:00:00 2001 From: Alex Gaynor Date: Sat, 15 Mar 2014 15:42:36 -0700 Subject: Don't put things with side effects in assert statements --- cryptography/hazmat/backends/openssl/backend.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cryptography/hazmat/backends/openssl/backend.py b/cryptography/hazmat/backends/openssl/backend.py index bdbbffd6..251dd09b 100644 --- a/cryptography/hazmat/backends/openssl/backend.py +++ b/cryptography/hazmat/backends/openssl/backend.py @@ -796,7 +796,8 @@ class _RSAVerificationContext(object): # occurs. assert res >= 0 if res == 0: - assert self._backend._consume_errors() + errors = self._backend._consume_errors() + assert errors raise InvalidSignature def _verify_pkcs1(self, rsa_cdata, evp_pkey, evp_md): @@ -813,7 +814,8 @@ class _RSAVerificationContext(object): # occurs. assert res >= 0 if res == 0: - assert self._backend._consume_errors() + errors = self._backend._consume_errors() + assert errors raise InvalidSignature -- cgit v1.2.3