From e7dc111a2fedbb42e008bb34a4e34835b3a63399 Mon Sep 17 00:00:00 2001 From: Paul Kehrer Date: Thu, 24 Dec 2015 21:44:57 -0600 Subject: don't reuse a variable, it's confusing --- src/cryptography/hazmat/backends/openssl/backend.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/cryptography/hazmat/backends/openssl/backend.py b/src/cryptography/hazmat/backends/openssl/backend.py index 0981b8e0..9ba0f3db 100644 --- a/src/cryptography/hazmat/backends/openssl/backend.py +++ b/src/cryptography/hazmat/backends/openssl/backend.py @@ -1513,15 +1513,17 @@ class Backend(object): pp, r = encode(self, extension.value) obj = _txt2obj_gc(self, extension.oid.dotted_string) - extension = self._lib.X509_EXTENSION_create_by_OBJ( + x509_extension = self._lib.X509_EXTENSION_create_by_OBJ( self._ffi.NULL, obj, 1 if extension.critical else 0, _encode_asn1_str_gc(self, pp[0], r) ) - self.openssl_assert(extension != self._ffi.NULL) - extension = self._ffi.gc(extension, self._lib.X509_EXTENSION_free) - x509_extensions.append(extension) + self.openssl_assert(x509_extension != self._ffi.NULL) + x509_extension = self._ffi.gc( + x509_extension, self._lib.X509_EXTENSION_free + ) + x509_extensions.append(x509_extension) return x509_extensions -- cgit v1.2.3