From b047617df8aeb51efed4ed761ff84c8b49cfced0 Mon Sep 17 00:00:00 2001 From: Paul Kehrer Date: Sat, 2 May 2015 19:34:51 -0500 Subject: add eq/ne to ExtendedKeyUsage --- src/cryptography/x509.py | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/cryptography/x509.py b/src/cryptography/x509.py index b22ac8be..6fcbfe6f 100644 --- a/src/cryptography/x509.py +++ b/src/cryptography/x509.py @@ -277,11 +277,10 @@ class Extension(object): class ExtendedKeyUsage(object): def __init__(self, usages): - for oid in usages: - if not isinstance(oid, ObjectIdentifier): - raise TypeError( - "Every item in the usages list must be an ObjectIdentifier" - ) + if not all(isinstance(x, ObjectIdentifier) for x in usages): + raise TypeError( + "Every item in the usages list must be an ObjectIdentifier" + ) self._usages = usages @@ -294,6 +293,17 @@ class ExtendedKeyUsage(object): def __repr__(self): return "".format(self._usages) + def __eq__(self, other): + if not isinstance(other, ExtendedKeyUsage): + return NotImplemented + + return ( + self._usages == other._usages + ) + + def __ne__(self, other): + return not self == other + class BasicConstraints(object): def __init__(self, ca, path_length): -- cgit v1.2.3 From f24bad7ee68fe0a10756f428d3bc742c53e22efa Mon Sep 17 00:00:00 2001 From: Paul Kehrer Date: Sat, 2 May 2015 19:36:20 -0500 Subject: let's not wrap this for no reason --- src/cryptography/x509.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src') diff --git a/src/cryptography/x509.py b/src/cryptography/x509.py index 6fcbfe6f..a37e2d08 100644 --- a/src/cryptography/x509.py +++ b/src/cryptography/x509.py @@ -297,9 +297,7 @@ class ExtendedKeyUsage(object): if not isinstance(other, ExtendedKeyUsage): return NotImplemented - return ( - self._usages == other._usages - ) + return self._usages == other._usages def __ne__(self, other): return not self == other -- cgit v1.2.3