From c1e84cb32296d9e448df1e9cabcc5312a85fb5fe Mon Sep 17 00:00:00 2001 From: Thomas Kriechbaumer Date: Wed, 8 Jul 2015 09:35:20 +0200 Subject: use websockets protocol --- libpathod/pathod.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libpathod/pathod.py') diff --git a/libpathod/pathod.py b/libpathod/pathod.py index 148fa7b2..daad64be 100644 --- a/libpathod/pathod.py +++ b/libpathod/pathod.py @@ -280,7 +280,7 @@ class PathodHandler(tcp.BaseHandler): retlog["cipher"] = self.get_current_cipher() m = utils.MemBool() - websocket_key = websockets.check_client_handshake(headers) + websocket_key = websockets.WebsocketsProtocol.check_client_handshake(headers) self.settings.websocket_key = websocket_key # If this is a websocket initiation, we respond with a proper -- cgit v1.2.3 From a2bf19125a92a4fa372708cf2cda7887ab62ac76 Mon Sep 17 00:00:00 2001 From: Thomas Kriechbaumer Date: Sat, 11 Jul 2015 23:47:43 +0200 Subject: refactor protocol-related pathod methods --- libpathod/pathod.py | 185 +++------------------------------------------------- 1 file changed, 10 insertions(+), 175 deletions(-) (limited to 'libpathod/pathod.py') diff --git a/libpathod/pathod.py b/libpathod/pathod.py index daad64be..31d821c2 100644 --- a/libpathod/pathod.py +++ b/libpathod/pathod.py @@ -8,7 +8,7 @@ import time from netlib import tcp, http, http2, wsgi, certutils, websockets, odict -from . import version, app, language, utils, log +from . import version, app, language, utils, log, protocols import language.http import language.actions import language.exceptions @@ -88,10 +88,6 @@ class PathodHandler(tcp.BaseHandler): self.sni = connection.get_servername() def http_serve_crafted(self, crafted, logctx): - """ - This method is HTTP/1 and HTTP/2 capable. - """ - error, crafted = self.server.check_policy( crafted, self.settings ) @@ -116,114 +112,9 @@ class PathodHandler(tcp.BaseHandler): return None, response_log return self.handle_http_request, response_log - def handle_websocket(self, logger): - while True: - with logger.ctx() as lg: - started = time.time() - try: - frm = websockets.Frame.from_file(self.rfile) - except tcp.NetLibIncomplete as e: - lg("Error reading websocket frame: %s" % e) - break - ended = time.time() - lg(frm.human_readable()) - retlog = dict( - type="inbound", - protocol="websockets", - started=started, - duration=ended - started, - frame=dict( - ), - cipher=None, - ) - if self.ssl_established: - retlog["cipher"] = self.get_current_cipher() - self.addlog(retlog) - ld = language.websockets.NESTED_LEADER - if frm.payload.startswith(ld): - nest = frm.payload[len(ld):] - try: - wf_gen = language.parse_websocket_frame(nest) - except language.exceptions.ParseException as v: - logger.write( - "Parse error in reflected frame specifcation:" - " %s" % v.msg - ) - return None, None - for frm in wf_gen: - with logger.ctx() as lg: - frame_log = language.serve( - frm, - self.wfile, - self.settings - ) - lg("crafting websocket spec: %s" % frame_log["spec"]) - self.addlog(frame_log) - return self.handle_websocket, None - - def handle_http_connect(self, connect, lg): - """ - This method is HTTP/1 only. - - Handle a CONNECT request. - """ - http.read_headers(self.rfile) - self.wfile.write( - 'HTTP/1.1 200 Connection established\r\n' + - ('Proxy-agent: %s\r\n' % version.NAMEVERSION) + - '\r\n' - ) - self.wfile.flush() - if not self.server.ssloptions.not_after_connect: - try: - cert, key, chain_file_ = self.server.ssloptions.get_cert( - connect[0] - ) - self.convert_to_ssl( - cert, - key, - handle_sni=self._handle_sni, - request_client_cert=self.server.ssloptions.request_client_cert, - cipher_list=self.server.ssloptions.ciphers, - method=self.server.ssloptions.ssl_version, - alpn_select=self.server.ssloptions.alpn_select, - ) - except tcp.NetLibError as v: - s = str(v) - lg(s) - return None, dict(type="error", msg=s) - return self.handle_http_request, None - - def handle_http_app(self, method, path, headers, content, lg): - """ - This method is HTTP/1 only. - - Handle a request to the built-in app. - """ - if self.server.noweb: - crafted = self.make_http_error_response("Access Denied") - language.serve(crafted, self.wfile, self.settings) - return None, dict( - type="error", - msg="Access denied: web interface disabled" - ) - lg("app: %s %s" % (method, path)) - req = wsgi.Request("http", method, path, headers, content) - flow = wsgi.Flow(self.address, req) - sn = self.connection.getsockname() - a = wsgi.WSGIAdaptor( - self.server.app, - sn[0], - self.server.address.port, - version.NAMEVERSION - ) - a.serve(flow, self.wfile) - return self.handle_http_request, None def handle_http_request(self, logger): """ - This method is HTTP/1 and HTTP/2 capable. - Returns a (handler, log) tuple. handler: Handler for the next request, or None to disconnect @@ -231,14 +122,13 @@ class PathodHandler(tcp.BaseHandler): """ with logger.ctx() as lg: if self.use_http2: - self.protocol.perform_server_connection_preface() stream_id, headers, body = self.protocol.read_request() method = headers[':method'] path = headers[':path'] headers = odict.ODict(headers) httpversion = "" else: - req = self.read_http_request(lg) + req = self.protocol.read_request(lg) if 'next_handle' in req: return req['next_handle'] if 'errors' in req: @@ -328,68 +218,15 @@ class PathodHandler(tcp.BaseHandler): lg ) if nexthandler and websocket_key: - return self.handle_websocket, retlog + self.protocol = protocols.websockets.WebsocketsProtocol(self) + return self.protocol.handle_websocket, retlog else: return nexthandler, retlog else: - return self.handle_http_app(method, path, headers, body, lg) - - def read_http_request(self, lg): - """ - This method is HTTP/1 only. - """ - line = http.get_request_line(self.rfile) - if not line: - # Normal termination - return dict() - - m = utils.MemBool() - if m(http.parse_init_connect(line)): - return dict(next_handle=self.handle_http_connect(m.v, lg)) - elif m(http.parse_init_proxy(line)): - method, _, _, _, path, httpversion = m.v - elif m(http.parse_init_http(line)): - method, path, httpversion = m.v - else: - s = "Invalid first line: %s" % repr(line) - lg(s) - return dict(errors=dict(type="error", msg=s)) - - headers = http.read_headers(self.rfile) - if headers is None: - s = "Invalid headers" - lg(s) - return dict(errors=dict(type="error", msg=s)) - - try: - body = http.read_http_body( - self.rfile, - headers, - None, - method, - None, - True, - ) - except http.HttpError as s: - s = str(s) - lg(s) - return dict(errors=dict(type="error", msg=s)) - - return dict( - method=method, - path=path, - headers=headers, - body=body, - httpversion=httpversion) + return self.protocol.handle_http_app(method, path, headers, body, lg) def make_http_error_response(self, reason, body=None): - """ - This method is HTTP/1 and HTTP/2 capable. - """ - if self.use_http2: - resp = language.http2.make_error_response(reason, body) - else: - resp = language.http.make_error_response(reason, body) + resp = self.protocol.make_error_response(reason, body) resp.is_error_response = True return resp @@ -421,14 +258,12 @@ class PathodHandler(tcp.BaseHandler): alp = self.get_alpn_proto_negotiated() if alp == http2.HTTP2Protocol.ALPN_PROTO_H2: - self.protocol = http2.HTTP2Protocol( - self, is_server=True, dump_frames=self.http2_framedump - ) + self.protocol = protocols.http2.HTTP2Protocol(self) self.use_http2 = True - # if not self.protocol: - # # TODO: create HTTP or Websockets protocol - # self.protocol = None + if not self.protocol: + self.protocol = protocols.http.HTTPProtocol(self) + lr = self.rfile if self.server.logreq else None lw = self.wfile if self.server.logresp else None logger = log.ConnectionLogger(self.logfp, self.server.hexdump, lr, lw) -- cgit v1.2.3 From 2b0465dbb93dd4bf0d6db366db597c05e92121d8 Mon Sep 17 00:00:00 2001 From: Thomas Kriechbaumer Date: Wed, 15 Jul 2015 22:04:25 +0200 Subject: use new netlib module names --- libpathod/pathod.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'libpathod/pathod.py') diff --git a/libpathod/pathod.py b/libpathod/pathod.py index 31d821c2..cfedc934 100644 --- a/libpathod/pathod.py +++ b/libpathod/pathod.py @@ -6,7 +6,8 @@ import threading import urllib import time -from netlib import tcp, http, http2, wsgi, certutils, websockets, odict +from netlib import tcp, http, wsgi, certutils, websockets, odict +from netlib.http import http1, http2 from . import version, app, language, utils, log, protocols import language.http -- cgit v1.2.3 From 6d5a3da9294d5bc6758ded173729042573c9fe5f Mon Sep 17 00:00:00 2001 From: Thomas Kriechbaumer Date: Sat, 18 Jul 2015 15:54:29 +0200 Subject: use new HTTP/1 protocol --- libpathod/pathod.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'libpathod/pathod.py') diff --git a/libpathod/pathod.py b/libpathod/pathod.py index cfedc934..f8607cca 100644 --- a/libpathod/pathod.py +++ b/libpathod/pathod.py @@ -123,11 +123,12 @@ class PathodHandler(tcp.BaseHandler): """ with logger.ctx() as lg: if self.use_http2: - stream_id, headers, body = self.protocol.read_request() - method = headers[':method'] - path = headers[':path'] - headers = odict.ODict(headers) - httpversion = "" + req = self.protocol.read_request() + method = req.method + path = req.path + headers = odict.ODictCaseless(req.headers) + httpversion = req.httpversion + stream_id = req.stream_id else: req = self.protocol.read_request(lg) if 'next_handle' in req: -- cgit v1.2.3 From 11ac387df2a49d132a08648b6cb5121224924c9d Mon Sep 17 00:00:00 2001 From: Thomas Kriechbaumer Date: Sun, 19 Jul 2015 18:17:09 +0200 Subject: rename content -> body --- libpathod/pathod.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libpathod/pathod.py') diff --git a/libpathod/pathod.py b/libpathod/pathod.py index f8607cca..6f25d0c8 100644 --- a/libpathod/pathod.py +++ b/libpathod/pathod.py @@ -212,7 +212,7 @@ class PathodHandler(tcp.BaseHandler): spec = anchor_gen.next() if self.use_http2 and isinstance(spec, language.http2.Response): - spec.stream_id = stream_id + spec.stream_id = req.stream_id lg("crafting spec: %s" % spec) nexthandler, retlog["response"] = self.http_serve_crafted( -- cgit v1.2.3 From 1a9c1a8c2d6ccedd2248a676a6b3235c8cf86147 Mon Sep 17 00:00:00 2001 From: Thomas Kriechbaumer Date: Sun, 19 Jul 2015 20:10:07 +0200 Subject: remove code duplication --- libpathod/pathod.py | 37 ++++++++++++++++++------------------- 1 file changed, 18 insertions(+), 19 deletions(-) (limited to 'libpathod/pathod.py') diff --git a/libpathod/pathod.py b/libpathod/pathod.py index 6f25d0c8..63dd1a15 100644 --- a/libpathod/pathod.py +++ b/libpathod/pathod.py @@ -122,26 +122,25 @@ class PathodHandler(tcp.BaseHandler): log: A dictionary, or None """ with logger.ctx() as lg: - if self.use_http2: + try: req = self.protocol.read_request() - method = req.method - path = req.path - headers = odict.ODictCaseless(req.headers) - httpversion = req.httpversion - stream_id = req.stream_id - else: - req = self.protocol.read_request(lg) - if 'next_handle' in req: - return req['next_handle'] - if 'errors' in req: - return None, req['errors'] - if 'method' not in req or 'path' not in req: - return None, None - method = req['method'] - path = req['path'] - headers = req['headers'] - body = req['body'] - httpversion = req['httpversion'] + except http.HttpError as s: + s = str(s) + lg(s) + return None, dict(type="error", msg=s) + + if isinstance(req, http.EmptyRequest): + return None, None + + if isinstance(req, http.ConnectRequest): + print([req.host, req.port, req.path]) + return self.protocol.handle_http_connect([req.host, req.port, req.path], lg) + + method = req.method + path = req.path + httpversion = req.httpversion + headers = odict.ODictCaseless(req.headers) + body = req.body clientcert = None if self.clientcert: -- cgit v1.2.3 From 3cf6bd5fb61d0b84033f4c86b3fc4a99d5287ac1 Mon Sep 17 00:00:00 2001 From: Thomas Kriechbaumer Date: Sun, 19 Jul 2015 22:30:06 +0200 Subject: remove debug prints --- libpathod/pathod.py | 1 - 1 file changed, 1 deletion(-) (limited to 'libpathod/pathod.py') diff --git a/libpathod/pathod.py b/libpathod/pathod.py index 63dd1a15..e634d7c2 100644 --- a/libpathod/pathod.py +++ b/libpathod/pathod.py @@ -133,7 +133,6 @@ class PathodHandler(tcp.BaseHandler): return None, None if isinstance(req, http.ConnectRequest): - print([req.host, req.port, req.path]) return self.protocol.handle_http_connect([req.host, req.port, req.path], lg) method = req.method -- cgit v1.2.3 From 6101d11d6ce412a19b542817bc8a7080a1f36758 Mon Sep 17 00:00:00 2001 From: Thomas Kriechbaumer Date: Mon, 20 Jul 2015 16:33:12 +0200 Subject: http2: remove odict workaround --- libpathod/pathod.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libpathod/pathod.py') diff --git a/libpathod/pathod.py b/libpathod/pathod.py index e634d7c2..6f07ecc5 100644 --- a/libpathod/pathod.py +++ b/libpathod/pathod.py @@ -138,7 +138,7 @@ class PathodHandler(tcp.BaseHandler): method = req.method path = req.path httpversion = req.httpversion - headers = odict.ODictCaseless(req.headers) + headers = req.headers body = req.body clientcert = None -- cgit v1.2.3 From dc42e335058365ed7288463dcd8e5f61b03a87a2 Mon Sep 17 00:00:00 2001 From: Thomas Kriechbaumer Date: Wed, 22 Jul 2015 13:04:14 +0200 Subject: fix bugs --- libpathod/pathod.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'libpathod/pathod.py') diff --git a/libpathod/pathod.py b/libpathod/pathod.py index 6f07ecc5..5c813cc5 100644 --- a/libpathod/pathod.py +++ b/libpathod/pathod.py @@ -85,7 +85,7 @@ class PathodHandler(tcp.BaseHandler): self.use_http2 = False self.http2_framedump = http2_framedump - def _handle_sni(self, connection): + def handle_sni(self, connection): self.sni = connection.get_servername() def http_serve_crafted(self, crafted, logctx): @@ -132,8 +132,8 @@ class PathodHandler(tcp.BaseHandler): if isinstance(req, http.EmptyRequest): return None, None - if isinstance(req, http.ConnectRequest): - return self.protocol.handle_http_connect([req.host, req.port, req.path], lg) + if req.method == 'CONNECT': + return self.protocol.handle_http_connect([req.host, req.port, req.httpversion], lg) method = req.method path = req.path @@ -239,7 +239,7 @@ class PathodHandler(tcp.BaseHandler): self.convert_to_ssl( cert, key, - handle_sni=self._handle_sni, + handle_sni=self.handle_sni, request_client_cert=self.server.ssloptions.request_client_cert, cipher_list=self.server.ssloptions.ciphers, method=self.server.ssloptions.ssl_version, -- cgit v1.2.3