From f74e561524d04c93cd7953f34e78ebe67eaa58a8 Mon Sep 17 00:00:00 2001 From: Maximilian Hils Date: Sun, 20 Nov 2016 17:21:21 +0100 Subject: rewrite absolute-form HTTP requests to relative form, fix #1759 (#1765) --- test/mitmproxy/test_server.py | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'test') diff --git a/test/mitmproxy/test_server.py b/test/mitmproxy/test_server.py index 9429ab0f..a7d8cea5 100644 --- a/test/mitmproxy/test_server.py +++ b/test/mitmproxy/test_server.py @@ -282,6 +282,21 @@ class TestHTTP(tservers.HTTPProxyTest, CommonMixin): assert d.content == b"bar" self.master.addons.remove(s) + def test_first_line_rewrite(self): + """ + If mitmproxy is a regular HTTP proxy, it must rewrite an absolute-form request like + GET http://example.com/foo HTTP/1.0 + to + GET /foo HTTP/1.0 + when sending the request upstream. While any server should technically accept + the absolute form, this is not the case in practice. + """ + req = "get:'%s/p/200'" % self.server.urlbase + p = self.pathoc() + with p.connect(): + assert p.request(req).status_code == 200 + assert self.server.last_log()["request"]["first_line_format"] == "relative" + class TestHTTPAuth(tservers.HTTPProxyTest): def test_auth(self): -- cgit v1.2.3