From 519be66fc59558971dd653afe69ccaf1a633b492 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Sun, 23 Dec 2018 20:03:35 +0100 Subject: Fix -Wsign-compare trouble Mostly by changing to `unsigned` types where applicable, sometimes `signed` types, and casting as a last resort. Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/flashrom/+/30409 Tested-by: build bot (Jenkins) Reviewed-by: Jacob Garber --- 82802ab.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to '82802ab.c') diff --git a/82802ab.c b/82802ab.c index 1046da48..281b66e2 100644 --- a/82802ab.c +++ b/82802ab.c @@ -126,7 +126,7 @@ int erase_block_82802ab(struct flashctx *flash, unsigned int page, /* chunksize is 1 */ int write_82802ab(struct flashctx *flash, const uint8_t *src, unsigned int start, unsigned int len) { - int i; + unsigned int i; chipaddr dst = flash->virtual_memory + start; for (i = 0; i < len; i++) { @@ -144,7 +144,7 @@ int unlock_28f004s5(struct flashctx *flash) { chipaddr bios = flash->virtual_memory; uint8_t mcfg, bcfg, need_unlock = 0, can_unlock = 0; - int i; + unsigned int i; /* Clear status register */ chip_writeb(flash, 0x50, bios); @@ -197,7 +197,7 @@ int unlock_lh28f008bjt(struct flashctx *flash) chipaddr bios = flash->virtual_memory; uint8_t mcfg, bcfg; uint8_t need_unlock = 0, can_unlock = 0; - int i; + unsigned int i; /* Wait if chip is busy */ wait_82802ab(flash); -- cgit v1.2.3