From 9e2dc2fc818cc9c1b46924e103ce669ad154b7ab Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Sun, 23 Dec 2018 22:00:47 +0100 Subject: Makefile,meson.build: Enable/assume -Wextra Enable all -Wextra warnings but -Wunused-parameter. Nobody seems to miss warnings about unused parameters and we have a lot unavoidable occurrences in flashrom because of common interfaces. Change-Id: Id2ece264c2d483e34019985dd3a7631c4889abe6 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/flashrom/+/30411 Tested-by: build bot (Jenkins) Reviewed-by: Jacob Garber --- Makefile | 2 +- meson.build | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/Makefile b/Makefile index b0c242d2..f0a1b619 100644 --- a/Makefile +++ b/Makefile @@ -30,7 +30,7 @@ INSTALL = install DIFF = diff PREFIX ?= /usr/local MANDIR ?= $(PREFIX)/share/man -CFLAGS ?= -Os -Wall -Wshadow -Wmissing-prototypes -Wwrite-strings +CFLAGS ?= -Os -Wall -Wextra -Wno-unused-parameter -Wshadow -Wmissing-prototypes -Wwrite-strings EXPORTDIR ?= . RANLIB ?= ranlib PKG_CONFIG ?= pkg-config diff --git a/meson.build b/meson.build index fda1ab8f..ca52ccf9 100644 --- a/meson.build +++ b/meson.build @@ -15,10 +15,8 @@ lt_version = '@0@.@1@.@2@'.format(lt_current, lt_age, lt_revision) warning_flags = [ '-Wwrite-strings', '-Wno-unused-parameter', - '-Wno-sign-compare', '-Wno-address-of-packed-member', '-Wno-enum-conversion', - '-Wno-missing-field-initializers', '-Wno-missing-braces', ] -- cgit v1.2.3