From 51c1f39e915e24707e5a0632d03816d1e19fae85 Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Thu, 27 May 2021 22:36:51 +1000 Subject: dummyflasher.c: Fix use-after-free issue Issue accidentally introduced in commit e3707bbf4. BUG=none BRANCH=none TEST=builds Change-Id: Ie12d6474ef5a7bb1afbbb9ec50b31b577da1a81b Signed-off-by: Edward O'Callaghan Reviewed-on: https://review.coreboot.org/c/flashrom/+/55014 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Anastasia Klimchuk --- dummyflasher.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'dummyflasher.c') diff --git a/dummyflasher.c b/dummyflasher.c index b7cfab8a..325263dd 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -700,12 +700,13 @@ int dummy_init(void) tmp = extract_programmer_param("spi_write_256_chunksize"); if (tmp) { data->spi_write_256_chunksize = strtoul(tmp, &endptr, 0); - free(tmp); if (*endptr != '\0' || data->spi_write_256_chunksize < 1) { msg_perr("invalid spi_write_256_chunksize\n"); + free(tmp); return 1; } } + free(tmp); tmp = extract_programmer_param("spi_blacklist"); if (tmp) { -- cgit v1.2.3