From 972cec282c061dadd3c501221d20d8b6437057e7 Mon Sep 17 00:00:00 2001 From: Michael Karcher Date: Thu, 26 Nov 2009 14:50:52 +0000 Subject: Refine support for the JEDEC Software Data Protection This patch removes the extremely dangerous unprotect_jedec function which is not used at all within flashrom code, and renames the misleadingly named protect_jedec function to start_program_jedec. Calls to protect_jedec after flashing are removed, because a) on LPC chips, the command sent by protoct_jedec is not even in the datasheet and b) on parallel chips, the block write command issued before already contained the software protection sequence, so software protection is definitely enabled. This patch also removes two clones of protect_jedec Background: JEDEC Software Data Protection started as an optional feature, which was disabled on the first single-voltage-flash chips. The software data protection is the need to prefix a write with a magic "write enable" command, while without write protection every write access into the chip's address space modifies flash content. This magic write enable command also tells the flash chip that the programmer obviously support sending write-enable commands and turns off the "any write modifies flash content" mode. There also exist a two-command (6 writes) sequence that disables Software Data Protection completey, which should only ever be used to prepare updating with a device that can't handle software data protection. Corresponding to flashrom svn r783. Signed-off-by: Michael Karcher Acked-by: Sean Nelson Acked-by: Carl-Daniel Hailfinger --- flash.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'flash.h') diff --git a/flash.h b/flash.h index 008af284..1a1d8f85 100644 --- a/flash.h +++ b/flash.h @@ -647,8 +647,7 @@ extern uint8_t *sb600_spibar; uint8_t oddparity(uint8_t val); void toggle_ready_jedec(chipaddr dst); void data_polling_jedec(chipaddr dst, uint8_t data); -void unprotect_jedec(chipaddr bios); -void protect_jedec(chipaddr bios); +void start_program_jedec(chipaddr bios); int write_byte_program_jedec(chipaddr bios, uint8_t *src, chipaddr dst); int probe_jedec(struct flashchip *flash); -- cgit v1.2.3