From d18c099cacca4f3d5635dd5df349efe8077c883e Mon Sep 17 00:00:00 2001 From: Rick Altherr Date: Thu, 22 Dec 2022 10:25:34 -0800 Subject: flashchips: Remove FEATURE_4BA_WREN for MT25QL128 and mark as tested Using both a Dediprog SF100 and a Bus Pirate, read and erase works correctly on a MT25QL128 but writes were failing to take effect. Currently, the entry in flashchips.c indicates that this device supports 4-byte addressing. Micron's datasheet indicates that it does not. After removing FEATURE_4BA_WREN from feature_bits, both SF100 and Bus Pirate were able to successfully read, erase, and write a MT25QL128 so also marking as tested. Change-Id: I6341456c722840a413bd2c51fe9a78bbda5cdbab Signed-off-by: Rick Altherr Reviewed-on: https://review.coreboot.org/c/flashrom/+/71206 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Anastasia Klimchuk --- flashchips.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'flashchips.c') diff --git a/flashchips.c b/flashchips.c index 9818eaca..625fe620 100644 --- a/flashchips.c +++ b/flashchips.c @@ -11997,8 +11997,8 @@ const struct flashchip flashchips[] = { .page_size = 256, /* supports SFDP */ /* OTP: 64B total; read 0x4B, write 0x42 */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_WREN, - .tested = TEST_UNTESTED, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .tested = TEST_OK_PREW, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .block_erasers = -- cgit v1.2.3