From 1b66464269ed829ba08b2736500712e50753cfab Mon Sep 17 00:00:00 2001 From: aarya Date: Thu, 10 Mar 2022 08:47:48 +0530 Subject: libflashrom.c: Fix unintialized value passed to function In function flash_layout_read_from_ifd variable chip_layout remains uninitialized if prepare_flash_access returns false. This uninitialized variable (which contains a garbage value) is passed to flashrom_layout_release. Thus initialize it with NULL. For completeness, also initialize dump_layout with NULL. Change-Id: Iacbd7bf9cdf897cc2a732c1dc6568845a4ab804d Signed-off-by: Aarya Chaumal Reviewed-on: https://review.coreboot.org/c/flashrom/+/62725 Reviewed-by: Felix Singer Reviewed-by: Edward O'Callaghan Reviewed-by: Nico Huber Reviewed-by: Anastasia Klimchuk Tested-by: build bot (Jenkins) --- libflashrom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libflashrom.c') diff --git a/libflashrom.c b/libflashrom.c index f2288fef..39b0c67b 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -442,7 +442,7 @@ int flashrom_layout_read_from_ifd(struct flashrom_layout **const layout, struct #ifndef __FLASHROM_LITTLE_ENDIAN__ return 6; #else - struct flashrom_layout *dump_layout, *chip_layout; + struct flashrom_layout *dump_layout = NULL, *chip_layout = NULL; int ret = 1; void *const desc = malloc(0x1000); -- cgit v1.2.3