From 9e72aa51a7a9ac5f041bacab75fd4be1e2a3356c Mon Sep 17 00:00:00 2001 From: Stefan Reinauer Date: Wed, 16 Sep 2009 08:18:08 +0000 Subject: Fix some of the issues reported by LLVM/clang's scan-build Corresponding to flashrom svn r722. Signed-off-by: Stefan Reinauer This commit fixes only some of the issues, those that were Acked-by: Carl-Daniel Hailfinger --- sharplhf00l04.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'sharplhf00l04.c') diff --git a/sharplhf00l04.c b/sharplhf00l04.c index 03bb2cef..c4c0f03e 100644 --- a/sharplhf00l04.c +++ b/sharplhf00l04.c @@ -73,7 +73,6 @@ int probe_lhf00l04(struct flashchip *flash) uint8_t wait_lhf00l04(chipaddr bios) { uint8_t status; - uint8_t id1, id2; chip_writeb(0x70, bios); if ((chip_readb(bios) & 0x80) == 0) { // it's busy @@ -82,13 +81,13 @@ uint8_t wait_lhf00l04(chipaddr bios) status = chip_readb(bios); - // put another command to get out of status register mode + // put another command to get out of status register mode. chip_writeb(0x90, bios); programmer_delay(10); - id1 = chip_readb(bios); - id2 = chip_readb(bios + 0x01); + chip_readb(bios); // vendor ID + chip_readb(bios + 0x01); // device ID // this is needed to jam it out of "read id" mode chip_writeb(0xAA, bios + 0x5555); -- cgit v1.2.3