From 62dd7c9e0f60d436c843bc7a654b9c60ef5871cc Mon Sep 17 00:00:00 2001 From: Anton Blanchard Date: Mon, 14 Oct 2019 15:21:40 +1100 Subject: Fix a couple of compiler warnings (#62) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I see a few compiler warnings on gcc 9.2: src/ghdl.cc: In function ‘Yosys::RTLIL::SigSpec get_src(std::vector&, GhdlSynth::Net)’: src/ghdl.cc:123:43: warning: ‘valzx’ may be used uninitialized in this function [-Wmaybe-uninitialized] 123 | switch(((val01 >> i)&1)+((valzx >> i)&1)*2) | ~~~~~~~^~~~~ src/ghdl.cc:123:26: warning: ‘val01’ may be used uninitialized in this function [-Wmaybe-uninitialized] 123 | switch(((val01 >> i)&1)+((valzx >> i)&1)*2) | ~~~~~~~^~~~~ src/ghdl.cc:99:26: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized] 99 | bits[i] = (val >> i) & 1 ? RTLIL::State::S1 : RTLIL::State::S0; | ~~~~~^~~~~ These both appear to be spurious, but initialize them to 0 to avoid the warning. --- src/ghdl.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/ghdl.cc b/src/ghdl.cc index 83b76d0..1d26ded 100644 --- a/src/ghdl.cc +++ b/src/ghdl.cc @@ -92,7 +92,7 @@ static RTLIL::SigSpec get_src(std::vector &net_map, Net n) { const unsigned wd = get_width(n); std::vector bits(wd); - unsigned int val; + unsigned int val = 0; for (unsigned i = 0; i < wd; i++) { if (i % 32 == 0) val = get_param_uns32(inst, i / 32); @@ -113,8 +113,8 @@ static RTLIL::SigSpec get_src(std::vector &net_map, Net n) { const unsigned wd = get_width(n); std::vector bits(wd); - unsigned int val01; - unsigned int valzx; + unsigned int val01 = 0; + unsigned int valzx = 0; for (unsigned i = 0; i < wd; i++) { if (i % 32 == 0) { val01 = get_param_uns32(inst, 2*(i / 32)); -- cgit v1.2.3