From bb754441c8acf70f82c1862a214e74164a403dc1 Mon Sep 17 00:00:00 2001
From: Vegard Storheil Eriksen <zyp@jvnv.net>
Date: Fri, 28 Feb 2020 03:05:39 +0100
Subject: gui: Fix undefined behavior in TreeModel.

std::sort() requires the comparison function to return false for even
comparison. Returning true results in undefined behavior and a potential
segfault.
---
 gui/treemodel.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'gui')

diff --git a/gui/treemodel.cc b/gui/treemodel.cc
index 97cc8883..e300c74d 100644
--- a/gui/treemodel.cc
+++ b/gui/treemodel.cc
@@ -135,7 +135,7 @@ void IdStringList::updateElements(Context *ctx, std::vector<IdString> elements)
         }
 
         // Same string.
-        return true;
+        return false;
     });
 }
 
-- 
cgit v1.2.3