From 83e60f0df6e1f80011d454103fd4156d27dc7d98 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20=C5=A0tetiar?= Date: Fri, 19 Jul 2019 16:10:35 +0200 Subject: firmware-utils: mkfwimage: enable extra compiler checks and fix them MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Let's enforce additional automatic checks enforced by the compiler in order to catch possible errors during compilation. Signed-off-by: Petr Štetiar --- tools/firmware-utils/src/mkfwimage.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'tools/firmware-utils/src') diff --git a/tools/firmware-utils/src/mkfwimage.c b/tools/firmware-utils/src/mkfwimage.c index 2b84d3db53..c919a2a131 100644 --- a/tools/firmware-utils/src/mkfwimage.c +++ b/tools/firmware-utils/src/mkfwimage.c @@ -262,7 +262,8 @@ static void usage(const char* progname) static void print_image_info(const image_info_t* im) { - int i = 0; + unsigned int i = 0; + INFO("Firmware version: '%s'\n" "Output file: '%s'\n" "Part count: %u\n", @@ -279,8 +280,6 @@ static void print_image_info(const image_info_t* im) } } - - static u_int32_t filelength(const char* file) { FILE *p; @@ -336,7 +335,7 @@ static int create_image_layout(const char* kernelfile, const char* rootfsfile, c */ static int validate_image_layout(image_info_t* im) { - int i; + unsigned int i; if (im->part_count == 0 || im->part_count > MAX_SECTIONS) { @@ -383,7 +382,7 @@ static int build_image(image_info_t* im) char* ptr; u_int32_t mem_size; FILE* f; - int i; + unsigned int i; // build in-memory buffer mem_size = sizeof(header_t); -- cgit v1.2.3