From e8f2c38720e391ce44154f17f3602484c1827a59 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Tue, 24 Mar 2020 23:13:02 +0200 Subject: [PATCH] media: bcm2835-unicam: Disable event-related ioctls on metadata node The unicam driver supports both the SOURCE_CHANGE and CTRL events. Both events are only generated on the image video node, so the event-related ioctls are useless on the medatada node. Disable them. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Naushir Patuck --- drivers/media/platform/bcm2835/bcm2835-unicam.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/media/platform/bcm2835/bcm2835-unicam.c +++ b/drivers/media/platform/bcm2835/bcm2835-unicam.c @@ -2374,6 +2374,11 @@ static int register_node(struct unicam_d return -ENOMEM; } + if (node->pad_id == METADATA_PAD) { + v4l2_disable_ioctl(vdev, VIDIOC_DQEVENT); + v4l2_disable_ioctl(vdev, VIDIOC_SUBSCRIBE_EVENT); + v4l2_disable_ioctl(vdev, VIDIOC_UNSUBSCRIBE_EVENT); + } if (node->pad_id == METADATA_PAD || !v4l2_subdev_has_op(unicam->sensor, video, s_std)) { v4l2_disable_ioctl(&node->video_dev, VIDIOC_S_STD);