diff options
| author | Erovia <Erovia@users.noreply.github.com> | 2020-03-29 14:29:44 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-03-29 14:29:44 +0200 |
| commit | c89c0841468ad23153a9fc9578d344845df31a88 (patch) | |
| tree | da17997995c2657511b3f4a8eefbdd0b3c3725a2 /docs/documentation_best_practices.md | |
| parent | 13fff52f6b629e4345e7ea2296b3d100aa9df245 (diff) | |
| download | firmware-c89c0841468ad23153a9fc9578d344845df31a88.tar.gz firmware-c89c0841468ad23153a9fc9578d344845df31a88.tar.bz2 firmware-c89c0841468ad23153a9fc9578d344845df31a88.zip | |
CLI: More MSYS2 fixes (#8577)
* CLI: More MSYS2 fixes
Now I can fully setup and work with qmk_firmware on an MSYS2
installation without any errors or exceptions.
* Apply suggestions from code review
Co-Authored-By: skullydazed <skullydazed@users.noreply.github.com>
* Some improvements
* Remove unnecessary import
* Remove slow, unused code
Getting the version from GIT was slow on both Windows and Docker.
Until we find a better, faster way, this is removed.
* remove unused imports
* Implement @vomindoraan's suggestions
* refine how we pick the shell to use
* Apply @fauxpark's suggestions
fauxpark investigated the topic of shells in MSYS2 a bit and we come to the conclusion that the safest bet was to just use the user's shell.
Anything more just opens up more edge-cases than it solves.
Co-Authored-By: Ryan <fauxpark@gmail.com>
* Use `platform_id` in doctor
This will bring it in line with the new code.
Co-authored-by: skullydazed <skullydazed@users.noreply.github.com>
Co-authored-by: skullY <skullydazed@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Diffstat (limited to 'docs/documentation_best_practices.md')
0 files changed, 0 insertions, 0 deletions