aboutsummaryrefslogtreecommitdiffstats
path: root/googlemock/src
diff options
context:
space:
mode:
authorGaspard Petit <gaspard.petit@eidosmontreal.com>2018-01-09 15:22:30 -0500
committerGaspard Petit <gaspard.petit@eidosmontreal.com>2018-01-09 15:22:30 -0500
commit5d96565ccc4b5bbd72100729361516de79b61353 (patch)
tree93aa8a57b1f8015974c44a6e5ec5efa8d69ddbab /googlemock/src
parent8b491162f79282b79292e0f4166194b3f7ccb7b1 (diff)
parent23015249236e60b94b5010330ef687de43d2e923 (diff)
downloadgoogletest-5d96565ccc4b5bbd72100729361516de79b61353.tar.gz
googletest-5d96565ccc4b5bbd72100729361516de79b61353.tar.bz2
googletest-5d96565ccc4b5bbd72100729361516de79b61353.zip
Merge branch 'master' into support_xboxone
Diffstat (limited to 'googlemock/src')
-rw-r--r--googlemock/src/gmock-internal-utils.cc2
-rw-r--r--googlemock/src/gmock-spec-builders.cc6
2 files changed, 4 insertions, 4 deletions
diff --git a/googlemock/src/gmock-internal-utils.cc b/googlemock/src/gmock-internal-utils.cc
index 6464abc2..91bf3fd9 100644
--- a/googlemock/src/gmock-internal-utils.cc
+++ b/googlemock/src/gmock-internal-utils.cc
@@ -71,7 +71,7 @@ GTEST_API_ string ConvertIdentifierNameToWords(const char* id_name) {
}
// This class reports Google Mock failures as Google Test failures. A
-// user can define another class in a similar fashion if he intends to
+// user can define another class in a similar fashion if they intend to
// use Google Mock with a testing framework other than Google Test.
class GoogleTestFailureReporter : public FailureReporterInterface {
public:
diff --git a/googlemock/src/gmock-spec-builders.cc b/googlemock/src/gmock-spec-builders.cc
index 0eaaee75..93a83ae5 100644
--- a/googlemock/src/gmock-spec-builders.cc
+++ b/googlemock/src/gmock-spec-builders.cc
@@ -353,10 +353,10 @@ UntypedFunctionMockerBase::UntypedInvokeWith(const void* const untyped_args)
// the behavior of ReportUninterestingCall().
const bool need_to_report_uninteresting_call =
// If the user allows this uninteresting call, we print it
- // only when he wants informational messages.
+ // only when they want informational messages.
reaction == kAllow ? LogIsVisible(kInfo) :
// If the user wants this to be a warning, we print it only
- // when he wants to see warnings.
+ // when they want to see warnings.
reaction == kWarn ? LogIsVisible(kWarning) :
// Otherwise, the user wants this to be an error, and we
// should always print detailed information in the error.
@@ -508,7 +508,7 @@ bool UntypedFunctionMockerBase::VerifyAndClearExpectationsLocked()
return expectations_met;
}
-CallReaction intToCallReaction(int mock_behavior) {
+static CallReaction intToCallReaction(int mock_behavior) {
if (mock_behavior >= kAllow && mock_behavior <= kFail) {
return static_cast<internal::CallReaction>(mock_behavior);
}