Merge pull request #2636 from alex/uri-hash

Implement __hash__ on UniformResourceIdentifier

2 files changed, 11 insertions, 0 deletions

diff --git a/src/cryptography/x509/general_name.py b/src/cryptography/x509/general_name.py
index f5bd30fb..049cd21f 100644
--- a/src/cryptography/x509/general_name.py
+++ b/src/cryptography/x509/general_name.py
@@ -155,6 +155,9 @@ class UniformResourceIdentifier(object):
     def __ne__(self, other):
         return not self == other
 
+    def __hash__(self):
+        return hash(self.value)
+
 
 @utils.register_interface(GeneralName)
 class DirectoryName(object):
diff --git a/tests/test_x509_ext.py b/tests/test_x509_ext.py
index 03a3730a..d04ce757 100644
--- a/tests/test_x509_ext.py
+++ b/tests/test_x509_ext.py
@@ -1480,6 +1480,14 @@ class TestUniformResourceIdentifier(object):
         )
         assert gn.value == u"ldap://cryptography:90/path?query=true#somedata"
 
+    def test_hash(self):
+        g1 = x509.UniformResourceIdentifier(u"http://host.com")
+        g2 = x509.UniformResourceIdentifier(u"http://host.com")
+        g3 = x509.UniformResourceIdentifier(u"http://other.com")
+
+        assert hash(g1) == hash(g2)
+        assert hash(g1) != hash(g3)
+
 
 class TestRegisteredID(object):
     def test_not_oid(self):