diff options
| author | Andre Caron <andre.l.caron@gmail.com> | 2015-05-19 08:48:12 -0400 |
|---|---|---|
| committer | Ian Cordasco <graffatcolmingov@gmail.com> | 2015-06-24 13:35:48 -0500 |
| commit | ca4c4462dcdbb72f653801f608c85696a4630349 (patch) | |
| tree | 0f7e34a7fbf09461a41df4c6389482162404d36a | |
| parent | 0ef595f1d9b5336872dc24d7d67c8cd127b31cea (diff) | |
| download | cryptography-ca4c4462dcdbb72f653801f608c85696a4630349.tar.gz cryptography-ca4c4462dcdbb72f653801f608c85696a4630349.tar.bz2 cryptography-ca4c4462dcdbb72f653801f608c85696a4630349.zip | |
Fixes memory allocation.
| -rw-r--r-- | src/cryptography/hazmat/backends/openssl/backend.py | 16 |
1 files changed, 4 insertions, 12 deletions
diff --git a/src/cryptography/hazmat/backends/openssl/backend.py b/src/cryptography/hazmat/backends/openssl/backend.py index f03ca077..bf838ead 100644 --- a/src/cryptography/hazmat/backends/openssl/backend.py +++ b/src/cryptography/hazmat/backends/openssl/backend.py @@ -113,18 +113,10 @@ def _encode_basic_constraints(backend, ca=False, pathlen=0, critical=False): if ca: constraints.pathlen = _encode_asn1_int(backend, pathlen) - # Allocate a buffer for encoded payload. - cdata = backend._ffi.new( - 'unsigned char[]', - 2048, # TODO: shrink to fit! - ) - assert cdata != backend._ffi.NULL - # Fetch the encoded payload. - p = backend._ffi.new('unsigned char*[1]') - assert p != backend._ffi.NULL - p[0] = cdata - r = backend._lib.i2d_BASIC_CONSTRAINTS(constraints, p) + pp = backend._ffi.new('unsigned char**') + assert pp != backend._ffi.NULL + r = backend._lib.i2d_BASIC_CONSTRAINTS(constraints, pp) assert r > 0 # Wrap that in an X509 extension object. @@ -132,7 +124,7 @@ def _encode_basic_constraints(backend, ca=False, pathlen=0, critical=False): backend._ffi.NULL, obj, 1 if critical else 0, - _encode_asn1_str(backend, cdata, r), + _encode_asn1_str(backend, pp[0], r), ) assert extension != backend._ffi.NULL return extension |