diff options
| author | Ian Cordasco <graffatcolmingov@gmail.com> | 2015-06-21 10:09:18 -0500 |
|---|---|---|
| committer | Ian Cordasco <graffatcolmingov@gmail.com> | 2015-06-24 13:35:50 -0500 |
| commit | f06b6be82300d9339bcfb062aedd7d7a3865aec9 (patch) | |
| tree | 3cf250d6200dd8366a4489cec1dba3a4241c649f /docs | |
| parent | d09ec37cb4c2995b1e2e2f88d187f4fbaef68ad8 (diff) | |
| download | cryptography-f06b6be82300d9339bcfb062aedd7d7a3865aec9.tar.gz cryptography-f06b6be82300d9339bcfb062aedd7d7a3865aec9.tar.bz2 cryptography-f06b6be82300d9339bcfb062aedd7d7a3865aec9.zip | |
Address review comments around add_extension method
- Fix typo in the docs (s/buidlder/builder/)
- Remove default from the method declaration and docs
- Replace ValueError with NotImpelementedError for unsupported X.509
extensions
- Add TODO comment as requested by Alex
- Fix test to pass critical=False since it no longer is a default value
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/x509.rst | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/docs/x509.rst b/docs/x509.rst index 84b3b8b4..c4c441e7 100644 --- a/docs/x509.rst +++ b/docs/x509.rst @@ -490,7 +490,7 @@ X.509 CSR (Certificate Signing Request) Builder Object >>> builder = builder.subject_name(x509.Name([ ... x509.NameAttribute(x509.OID_COMMON_NAME, u'cryptography.io'), ... ])) - >>> buidlder = builder.add_extension( + >>> builder = builder.add_extension( ... x509.BasicConstraints(ca=False, path_length=None), critical=True, ... ) >>> request = builder.sign( @@ -506,7 +506,7 @@ X.509 CSR (Certificate Signing Request) Builder Object :returns: A new :class:`~cryptography.x509.CertificateSigningRequestBuilder`. - .. method:: add_extension(extension, critical=False) + .. method:: add_extension(extension, critical) :param extension: The :class:`~cryptography.x509.Extension` to add to the request. |