diff options
| author | Ian Cordasco <graffatcolmingov@gmail.com> | 2015-06-21 10:09:18 -0500 |
|---|---|---|
| committer | Ian Cordasco <graffatcolmingov@gmail.com> | 2015-06-24 13:35:50 -0500 |
| commit | f06b6be82300d9339bcfb062aedd7d7a3865aec9 (patch) | |
| tree | 3cf250d6200dd8366a4489cec1dba3a4241c649f /tests/test_x509.py | |
| parent | d09ec37cb4c2995b1e2e2f88d187f4fbaef68ad8 (diff) | |
| download | cryptography-f06b6be82300d9339bcfb062aedd7d7a3865aec9.tar.gz cryptography-f06b6be82300d9339bcfb062aedd7d7a3865aec9.tar.bz2 cryptography-f06b6be82300d9339bcfb062aedd7d7a3865aec9.zip | |
Address review comments around add_extension method
- Fix typo in the docs (s/buidlder/builder/)
- Remove default from the method declaration and docs
- Replace ValueError with NotImpelementedError for unsupported X.509
extensions
- Add TODO comment as requested by Alex
- Fix test to pass critical=False since it no longer is a default value
Diffstat (limited to 'tests/test_x509.py')
| -rw-r--r-- | tests/test_x509.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tests/test_x509.py b/tests/test_x509.py index 441d634b..78def5f8 100644 --- a/tests/test_x509.py +++ b/tests/test_x509.py @@ -784,9 +784,10 @@ class TestCertificateSigningRequestBuilder(object): x509.NameAttribute(x509.OID_COMMON_NAME, u'cryptography.io'), ]) ) - with pytest.raises(ValueError): + with pytest.raises(NotImplementedError): builder.add_extension( - x509.AuthorityKeyIdentifier('keyid', None, None) + x509.AuthorityKeyIdentifier('keyid', None, None), + critical=False, ) |