diff options
| author | Paul Kehrer <paul.l.kehrer@gmail.com> | 2017-12-01 10:48:56 +0800 |
|---|---|---|
| committer | Alex Gaynor <alex.gaynor@gmail.com> | 2017-11-30 20:48:56 -0600 |
| commit | 4662d44fd3db5078a1882100653a3dbab3e3c7a1 (patch) | |
| tree | 8338b438c3a388fc3f5026e87b90cfe0a04ab462 /tests/x509/test_x509_crlbuilder.py | |
| parent | 66460d8f62b3f27a009bb61be6ce7675c8451b6e (diff) | |
| download | cryptography-4662d44fd3db5078a1882100653a3dbab3e3c7a1.tar.gz cryptography-4662d44fd3db5078a1882100653a3dbab3e3c7a1.tar.bz2 cryptography-4662d44fd3db5078a1882100653a3dbab3e3c7a1.zip | |
Fix ASN1 string type encoding for several Name OIDs (#4035)
* Fix ASN1 string type encoding for several Name OIDs
When we changed over to the new type encoding system we didn't verify
that the new code exactly matched the ASN1 string types that OpenSSL was
previously choosing. This caused serialNumber, dnQualifier,
emailAddress, and domainComponent to change from their proper encodings
to UTF8String as of version 2.1.
Now we check to see if there's a sentinel value (indicating no custom
type has been passed) and then check if the OID has a different default
than UTF8. If it does, we set it.
This PR also adds tests for the ASN1 string type of ever supported
NameOID.
* review feedback
Diffstat (limited to 'tests/x509/test_x509_crlbuilder.py')
0 files changed, 0 insertions, 0 deletions