aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMaximilian Hils <git@maximilianhils.com>2018-05-29 15:15:07 +0200
committerGitHub <noreply@github.com>2018-05-29 15:15:07 +0200
commit54ee135f655bd17759b7d1acf965d3d9583cab32 (patch)
tree68811a9df164a40f40ad6043aa7513ad79c11a8c
parent8ebcf8ec9647842bfd48e9c890109d2399621a4d (diff)
downloadmitmproxy-54ee135f655bd17759b7d1acf965d3d9583cab32.tar.gz
mitmproxy-54ee135f655bd17759b7d1acf965d3d9583cab32.tar.bz2
mitmproxy-54ee135f655bd17759b7d1acf965d3d9583cab32.zip
windows transparent mode: always recalculate checksum
-rw-r--r--mitmproxy/platform/windows.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/mitmproxy/platform/windows.py b/mitmproxy/platform/windows.py
index 7e4b48fe..b849afa5 100644
--- a/mitmproxy/platform/windows.py
+++ b/mitmproxy/platform/windows.py
@@ -338,7 +338,9 @@ class RedirectLocal(Redirect):
if pid not in self.trusted_pids:
self.redirect_request(packet)
else:
- self.windivert.send(packet, recalculate_checksum=False)
+ # It's not really clear why we need to recalculate the checksum here,
+ # but this was identified as necessary in https://github.com/mitmproxy/mitmproxy/pull/3174.
+ self.windivert.send(packet, recalculate_checksum=True)
TConnection = typing.Tuple[str, int]