aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAldo Cortesi <aldo@corte.si>2018-04-18 08:21:08 +1200
committerAldo Cortesi <aldo@corte.si>2018-04-18 08:21:08 +1200
commit8396244729f67ab5ca3c750b280aef2bc0b34006 (patch)
treed86a5df0f64e3a4851c81519264e9a3b02c6baf4
parent633023701b9f57b19d6e86af96390575be8ef33a (diff)
downloadmitmproxy-8396244729f67ab5ca3c750b280aef2bc0b34006.tar.gz
mitmproxy-8396244729f67ab5ca3c750b280aef2bc0b34006.tar.bz2
mitmproxy-8396244729f67ab5ca3c750b280aef2bc0b34006.zip
mitmweb: shift to use new run_loop wrapper on master
Fixes #3067
-rw-r--r--mitmproxy/tools/web/master.py16
1 files changed, 2 insertions, 14 deletions
diff --git a/mitmproxy/tools/web/master.py b/mitmproxy/tools/web/master.py
index 575694c7..e2c60d94 100644
--- a/mitmproxy/tools/web/master.py
+++ b/mitmproxy/tools/web/master.py
@@ -105,33 +105,21 @@ class WebMaster(master.Master):
def run(self): # pragma: no cover
AsyncIOMainLoop().install()
-
iol = tornado.ioloop.IOLoop.instance()
-
http_server = tornado.httpserver.HTTPServer(self.app)
http_server.listen(self.options.web_port, self.options.web_iface)
-
- iol.add_callback(self.start)
-
web_url = "http://{}:{}/".format(self.options.web_iface, self.options.web_port)
self.log.info(
"Web server listening at {}".format(web_url),
)
-
+ # FIXME: This should be in an addon hooked to the "running" event, not in master
if self.options.web_open_browser:
success = open_browser(web_url)
if not success:
self.log.info(
"No web browser found. Please open a browser and point it to {}".format(web_url),
)
- try:
- iol.start()
- except KeyboardInterrupt:
- self.shutdown()
-
- def shutdown(self):
- tornado.ioloop.IOLoop.instance().stop()
- super().shutdown()
+ self.run_loop(iol.start)
def open_browser(url: str) -> bool: