diff options
| author | Aldo Cortesi <aldo@nullcube.com> | 2016-12-16 11:47:59 +1300 |
|---|---|---|
| committer | Aldo Cortesi <aldo@nullcube.com> | 2016-12-16 11:57:45 +1300 |
| commit | e387c68b387a0c664743d416d9b32a669f3c1c16 (patch) | |
| tree | 10ad513c0a14cbe273d6aa6bd4677734af7370c1 | |
| parent | 6b5673e84911f3e2b1599c22c9b4f482a55b9ef1 (diff) | |
| download | mitmproxy-e387c68b387a0c664743d416d9b32a669f3c1c16.tar.gz mitmproxy-e387c68b387a0c664743d416d9b32a669f3c1c16.tar.bz2 mitmproxy-e387c68b387a0c664743d416d9b32a669f3c1c16.zip | |
console: mark view indiciator, fix empty flow list behaviour
Fixes #1782
| -rw-r--r-- | mitmproxy/tools/console/flowlist.py | 4 | ||||
| -rw-r--r-- | mitmproxy/tools/console/statusbar.py | 6 | ||||
| -rw-r--r-- | test/mitmproxy/addons/test_view.py | 5 |
3 files changed, 12 insertions, 3 deletions
diff --git a/mitmproxy/tools/console/flowlist.py b/mitmproxy/tools/console/flowlist.py index fd6b3bab..7d502cd1 100644 --- a/mitmproxy/tools/console/flowlist.py +++ b/mitmproxy/tools/console/flowlist.py @@ -178,8 +178,6 @@ class FlowItem(urwid.WidgetWrap): elif key == "m": self.flow.marked = not self.flow.marked signals.flowlist_change.send(self) - elif key == "M": - self.master.view.toggle_marked() elif key == "r": try: self.master.replay_request(self.flow) @@ -375,6 +373,8 @@ class FlowListBox(urwid.ListBox): prompt = "Load flows", callback = self.master.load_flows_callback ) + elif key == "M": + self.master.view.toggle_marked() elif key == "n": signals.status_prompt_onekey.send( prompt = "Method", diff --git a/mitmproxy/tools/console/statusbar.py b/mitmproxy/tools/console/statusbar.py index dce8605f..785dc766 100644 --- a/mitmproxy/tools/console/statusbar.py +++ b/mitmproxy/tools/console/statusbar.py @@ -263,8 +263,12 @@ class StatusBar(urwid.WidgetWrap): else: arrow = common.SYMBOL_DOWN + marked = "" + if self.master.view.show_marked: + marked = "M" + t = [ - ('heading', ("%s [%s/%s]" % (arrow, offset, fc)).ljust(11)), + ('heading', ("%s %s [%s/%s]" % (arrow, marked, offset, fc)).ljust(11)), ] if self.master.server.bound: diff --git a/test/mitmproxy/addons/test_view.py b/test/mitmproxy/addons/test_view.py index 27e10058..96f213e2 100644 --- a/test/mitmproxy/addons/test_view.py +++ b/test/mitmproxy/addons/test_view.py @@ -123,6 +123,11 @@ def test_filter(): v.set_filter(None) assert len(v) == 4 + v.toggle_marked() + assert len(v) == 0 + v.toggle_marked() + assert len(v) == 4 + v[1].marked = True v.toggle_marked() assert len(v) == 1 |