diff options
| author | Maximilian Hils <git@maximilianhils.com> | 2017-12-29 22:44:18 +0100 |
|---|---|---|
| committer | Thomas Kriechbaumer <thomas@kriechbaumer.name> | 2017-12-29 22:56:29 +0100 |
| commit | 62326227740d3808c0886ed381cb976a6b2f8b03 (patch) | |
| tree | bb86ed2d55822470608568115ce41ce51c6edba8 /docs/tutorials | |
| parent | 59c277effd016fdf771a65aaaa87526ff5fe869e (diff) | |
| download | mitmproxy-62326227740d3808c0886ed381cb976a6b2f8b03.tar.gz mitmproxy-62326227740d3808c0886ed381cb976a6b2f8b03.tar.bz2 mitmproxy-62326227740d3808c0886ed381cb976a6b2f8b03.zip | |
fix Flow.kill behaviour
This now just sets a kill reply instead of committing directly.
First, this seems like the more sane thing to do.
Second, we have an iffy race condition where we call Reply.commit()
before the addonmanager finishes its invocation, the proxy thread then progresses
and sets a new flow.reply attribute, and the addonmanager then gets confused
when finishing. This commit doesn't fix that, but mitigates it for Flow.kill
which is now committed by the addonmanager.
Diffstat (limited to 'docs/tutorials')
0 files changed, 0 insertions, 0 deletions