diff options
| author | Will Coster <willcoster@google.com> | 2016-02-13 16:12:56 -0800 |
|---|---|---|
| committer | Will Coster <willcoster@google.com> | 2016-02-13 16:16:12 -0800 |
| commit | d60257e767a8cc47054504c1e862196a19fda864 (patch) | |
| tree | 418135430072d7ec08102bb9333f682865d9e7b2 /libmproxy/models/http.py | |
| parent | bd68b4f6781dfb7f2e147fdcfcd8466cbb747ab3 (diff) | |
| download | mitmproxy-d60257e767a8cc47054504c1e862196a19fda864.tar.gz mitmproxy-d60257e767a8cc47054504c1e862196a19fda864.tar.bz2 mitmproxy-d60257e767a8cc47054504c1e862196a19fda864.zip | |
Do not send Proxy-Agent in CONNECT responses
Sending any headers at all in response to a CONNECT request breaks
proxying Android emulators on all non-80 ports.
Issue: #783
Diffstat (limited to 'libmproxy/models/http.py')
| -rw-r--r-- | libmproxy/models/http.py | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/libmproxy/models/http.py b/libmproxy/models/http.py index 3c024e76..a2a345d7 100644 --- a/libmproxy/models/http.py +++ b/libmproxy/models/http.py @@ -456,14 +456,13 @@ def make_connect_request(address): def make_connect_response(http_version): - headers = Headers( - Proxy_Agent=version.NAMEVERSION - ) + # Do not send any response headers as it breaks proxying non-80 ports on + # Android emulators using the -http-proxy option. return HTTPResponse( http_version, 200, "Connection established", - headers, + Headers(), "", ) |