aboutsummaryrefslogtreecommitdiffstats
path: root/test/mitmproxy/addons/test_browser.py
diff options
context:
space:
mode:
authorAldo Cortesi <aldo@corte.si>2017-12-12 09:10:05 +1300
committerGitHub <noreply@github.com>2017-12-12 09:10:05 +1300
commit25cf3db65853d66832e8bef81e7a431181172bd2 (patch)
tree170034aac0b28e93dfa7e6735b873593d5a5a30a /test/mitmproxy/addons/test_browser.py
parentb09c28d8a6fcd2af4a43b968b800d44c5a8c836e (diff)
parent4912920573c71a49670928b19893b965d199f836 (diff)
downloadmitmproxy-25cf3db65853d66832e8bef81e7a431181172bd2.tar.gz
mitmproxy-25cf3db65853d66832e8bef81e7a431181172bd2.tar.bz2
mitmproxy-25cf3db65853d66832e8bef81e7a431181172bd2.zip
Merge pull request #2661 from mhils/browser-win
Fix browser addon on Windows
Diffstat (limited to 'test/mitmproxy/addons/test_browser.py')
-rw-r--r--test/mitmproxy/addons/test_browser.py13
1 files changed, 12 insertions, 1 deletions
diff --git a/test/mitmproxy/addons/test_browser.py b/test/mitmproxy/addons/test_browser.py
index d1b32186..407a3fe6 100644
--- a/test/mitmproxy/addons/test_browser.py
+++ b/test/mitmproxy/addons/test_browser.py
@@ -5,7 +5,8 @@ from mitmproxy.test import taddons
def test_browser():
- with mock.patch("subprocess.Popen") as po:
+ with mock.patch("subprocess.Popen") as po, mock.patch("shutil.which") as which:
+ which.return_value = "chrome"
b = browser.Browser()
with taddons.context() as tctx:
b.start()
@@ -18,3 +19,13 @@ def test_browser():
assert tctx.master.has_log("already running")
b.done()
assert not b.browser
+
+
+def test_no_browser():
+ with mock.patch("shutil.which") as which:
+ which.return_value = False
+
+ b = browser.Browser()
+ with taddons.context() as tctx:
+ b.start()
+ assert tctx.master.has_log("platform is not supported")