diff options
author | Vincent Breitmoser <valodim@mugenguild.com> | 2016-01-11 17:30:03 +0100 |
---|---|---|
committer | Vincent Breitmoser <valodim@mugenguild.com> | 2016-01-11 17:30:03 +0100 |
commit | e66c27c08129b278bcc699a7f2511d69d5dc0a29 (patch) | |
tree | 35135cd2323f2bcf383ac2b9c123791ef395fcb1 /OpenKeychain/src/main/java | |
parent | dfeb1223783b5b47c8c3d8e9b1703df4e5512bb7 (diff) | |
download | open-keychain-e66c27c08129b278bcc699a7f2511d69d5dc0a29.tar.gz open-keychain-e66c27c08129b278bcc699a7f2511d69d5dc0a29.tar.bz2 open-keychain-e66c27c08129b278bcc699a7f2511d69d5dc0a29.zip |
passphrasecache: update defaults, add "forever" setting
Diffstat (limited to 'OpenKeychain/src/main/java')
3 files changed, 10 insertions, 4 deletions
diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java index 606daabed..f9ab58f5b 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java @@ -365,6 +365,8 @@ public class PassphraseCacheService extends Service { CachedPassphrase cachedPassphrase; if (timeoutTtl == 0L) { cachedPassphrase = CachedPassphrase.getPassphraseLock(passphrase, primaryUserID); + } else if (timeoutTtl >= Integer.MAX_VALUE) { + cachedPassphrase = CachedPassphrase.getPassphraseNoTimeout(passphrase, primaryUserID); } else { cachedPassphrase = CachedPassphrase.getPassphraseTtlTimeout(passphrase, primaryUserID, timeoutTtl); @@ -427,7 +429,10 @@ public class PassphraseCacheService extends Service { // Stop all ttl alarms for (int i = 0; i < mPassphraseCache.size(); i++) { - am.cancel(buildIntent(this, mPassphraseCache.keyAt(i))); + CachedPassphrase cachedPassphrase = mPassphraseCache.valueAt(i); + if (cachedPassphrase.mTimeoutMode == TimeoutMode.TTL) { + am.cancel(buildIntent(this, mPassphraseCache.keyAt(i))); + } } mPassphraseCache.clear(); diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/SettingsCacheTTLFragment.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/SettingsCacheTTLFragment.java index 1c769e7a2..b811d51b5 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/SettingsCacheTTLFragment.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/SettingsCacheTTLFragment.java @@ -77,7 +77,6 @@ public class SettingsCacheTTLFragment extends Fragment { recyclerView.setAdapter(mAdapter); recyclerView.addItemDecoration(new DividerItemDecoration(getActivity(), DividerItemDecoration.VERTICAL_LIST)); - } private void savePreference() { diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/util/Preferences.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/util/Preferences.java index 8eafbbdf1..b3d679a0e 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/util/Preferences.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/util/Preferences.java @@ -322,11 +322,13 @@ public class Preferences { static { HashMap<Integer,Integer> cacheTtlNames = new HashMap<>(); cacheTtlNames.put(0, R.string.cache_ttl_lock_screen); - cacheTtlNames.put(60 * 5, R.string.cache_ttl_five_minutes); + cacheTtlNames.put(60 * 10, R.string.cache_ttl_ten_minutes); + cacheTtlNames.put(60 * 30, R.string.cache_ttl_thirty_minutes); cacheTtlNames.put(60 * 60, R.string.cache_ttl_one_hour); cacheTtlNames.put(60 * 60 * 3, R.string.cache_ttl_three_hours); cacheTtlNames.put(60 * 60 * 24, R.string.cache_ttl_one_day); cacheTtlNames.put(60 * 60 * 24 * 3, R.string.cache_ttl_three_days); + cacheTtlNames.put(Integer.MAX_VALUE, R.string.cache_ttl_forever); CACHE_TTL_NAMES = Collections.unmodifiableMap(cacheTtlNames); CACHE_TTLS = new ArrayList<>(CacheTTLPrefs.CACHE_TTL_NAMES.keySet()); @@ -352,7 +354,7 @@ public class Preferences { public static CacheTTLPrefs getDefault() { ArrayList<String> ttlStrings = new ArrayList<>(); - ttlStrings.add(Integer.toString(60 * 5)); + ttlStrings.add(Integer.toString(0)); ttlStrings.add(Integer.toString(60 * 60)); ttlStrings.add(Integer.toString(60 * 60 * 24)); return new CacheTTLPrefs(ttlStrings); |