diff options
| author | Edward O'Callaghan <quasisec@google.com> | 2022-06-30 18:30:20 +1000 |
|---|---|---|
| committer | Anastasia Klimchuk <aklm@chromium.org> | 2022-07-05 06:25:59 +0000 |
| commit | 6599e34d5dc84440d7cfdf002cb523d54b583087 (patch) | |
| tree | 890f61762260bf83f11475b0d8d28b93b992dd4d | |
| parent | bfb80286e1be868d9ff4c2ee2acf72f7fb9302da (diff) | |
| download | flashrom-6599e34d5dc84440d7cfdf002cb523d54b583087.tar.gz flashrom-6599e34d5dc84440d7cfdf002cb523d54b583087.tar.bz2 flashrom-6599e34d5dc84440d7cfdf002cb523d54b583087.zip | |
realtek_mst_i2c_spi.c: Clarify gpio pin 88 comment to be more exacting
Avoid confusion from the comment. While technically a GPIO
can do anything, like drive a LED. The GPIO pin 88 *is*
meant to drive the WP line of the SPI flash, that is its
purpose.
Change-Id: If718d41a27931380e5f7ebdb75b9863da0c61559
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/65546
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-by: Thomas Heijligen <src@posteo.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | realtek_mst_i2c_spi.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/realtek_mst_i2c_spi.c b/realtek_mst_i2c_spi.c index f03c20a6..8c9bae1a 100644 --- a/realtek_mst_i2c_spi.c +++ b/realtek_mst_i2c_spi.c @@ -191,8 +191,7 @@ static int realtek_mst_i2c_spi_read_indexed_register(int fd, uint16_t address, u } -/* Toggle the GPIO pin 88, this could be routed to different controls like write - * protection or a led. */ +/* Toggle the GPIO pin 88, reserved for write protection pin of the external flash. */ static int realtek_mst_i2c_spi_toggle_gpio_88_strap(int fd, bool toggle) { int ret = 0; |