diff options
author | Edward O'Callaghan <quasisec@google.com> | 2022-10-11 14:24:17 +1100 |
---|---|---|
committer | Felix Singer <felixsinger@posteo.net> | 2022-10-15 14:37:00 +0000 |
commit | 71c65023785571074c4dc8fa93e393db8eed022d (patch) | |
tree | 01e69b06fae87495c4d9098a4118e1444d78042e | |
parent | 955c01f5c4989ad2b0a1feec948257bf806cf1f8 (diff) | |
download | flashrom-71c65023785571074c4dc8fa93e393db8eed022d.tar.gz flashrom-71c65023785571074c4dc8fa93e393db8eed022d.tar.bz2 flashrom-71c65023785571074c4dc8fa93e393db8eed022d.zip |
layout.c: Use calloc() to ensure a zeroed layout
No need to malloc() and then do a DIY memset to zero of the
heap. Just use calloc(1, ..) to get a zeroed heap.
Change-Id: Id6cf2c4591aec0620f15d8a39495d2bff6597f96
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/68279
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
-rw-r--r-- | layout.c | 4 |
1 files changed, 1 insertions, 3 deletions
@@ -355,14 +355,12 @@ const struct romentry *layout_next( int flashrom_layout_new(struct flashrom_layout **const layout) { - *layout = malloc(sizeof(**layout)); + *layout = calloc(1, sizeof(**layout)); if (!*layout) { msg_gerr("Error creating layout: %s\n", strerror(errno)); return 1; } - const struct flashrom_layout tmp = { 0 }; - **layout = tmp; return 0; } |