diff options
| author | Nico Huber <nico.h@gmx.de> | 2019-10-04 17:34:22 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2019-10-05 23:26:25 +0000 |
| commit | 961f4a1f29787cbb6bd9a8a43b6ac4f3f0d024c0 (patch) | |
| tree | 13023be2c6cc0140cbfa97dee108a441e696b638 /dummyflasher.c | |
| parent | b417c0c2d2616feff30cc87316a278055da8c64a (diff) | |
| download | flashrom-961f4a1f29787cbb6bd9a8a43b6ac4f3f0d024c0.tar.gz flashrom-961f4a1f29787cbb6bd9a8a43b6ac4f3f0d024c0.tar.bz2 flashrom-961f4a1f29787cbb6bd9a8a43b6ac4f3f0d024c0.zip | |
Fix more sign-compare issues
The one in the `dummyflasher` is a little peculiar. We actually never
knew the type of the `st_size` field in `struct stat`. It happens to
be `signed` in some systems (e.g. DJGPP).
Change-Id: If36ba22606021400b385ea6083eacc7b360c20c5
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/35800
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jacob Garber <jgarber1@ualberta.ca>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'dummyflasher.c')
| -rw-r--r-- | dummyflasher.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/dummyflasher.c b/dummyflasher.c index 2d7fa858..b9f61267 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -387,7 +387,7 @@ int dummy_init(void) if (!stat(emu_persistent_image, &image_stat)) { msg_pdbg("Found persistent image %s, %jd B ", emu_persistent_image, (intmax_t)image_stat.st_size); - if (image_stat.st_size == emu_chip_size) { + if ((uintmax_t)image_stat.st_size == emu_chip_size) { msg_pdbg("matches.\n"); msg_pdbg("Reading %s\n", emu_persistent_image); if (read_buf_from_file(flashchip_contents, emu_chip_size, |