diff options
author | Nico Huber <nico.h@gmx.de> | 2021-06-20 15:59:57 +0200 |
---|---|---|
committer | Nico Huber <nico.h@gmx.de> | 2021-06-25 12:54:52 +0000 |
commit | f0915dbc6b0f3af6931280c9e79b72f384926615 (patch) | |
tree | c8a4648505173a8cd2260ed503b121e845876737 /edi.h | |
parent | 2ac057cb393130bc5352ec69588fb3cce4e8fa6d (diff) | |
download | flashrom-f0915dbc6b0f3af6931280c9e79b72f384926615.tar.gz flashrom-f0915dbc6b0f3af6931280c9e79b72f384926615.tar.bz2 flashrom-f0915dbc6b0f3af6931280c9e79b72f384926615.zip |
ft2232_spi: Revise comments about output pin states
The meaning of the variables is easy to misunderstand as some
states are merely implicit: All output pins that are not set
in the `cs_bits` mask will be constantly driven low. This may
be sheer coincidence as all programmers that need additional
pins driven use active-low signals to enable buffers.
While other pins stay low, *all* pins set in the `cs_bits`
mask are supposed to be toggled during SPI transactions.
Also drop some irritating dead code and try to explain things
in a comment.
Change-Id: I2b84ede01759c80f69d5ad17e43783d09ecd1107
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/55695
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'edi.h')
0 files changed, 0 insertions, 0 deletions