diff options
| author | Edward O'Callaghan <quasisec@google.com> | 2022-11-28 18:00:37 +1100 |
|---|---|---|
| committer | Edward O'Callaghan <quasisec@chromium.org> | 2023-01-15 01:21:10 +0000 |
| commit | 2b72cdb4f44fa3828a7cac09f288d94e9ce12ecd (patch) | |
| tree | 771c00d0a632b84b3f3454808a5d8b1e7a9b00a1 /include | |
| parent | 0bc84bfe4a2b9bb8cbfa719f6221eef2d8f866ca (diff) | |
| download | flashrom-2b72cdb4f44fa3828a7cac09f288d94e9ce12ecd.tar.gz flashrom-2b72cdb4f44fa3828a7cac09f288d94e9ce12ecd.tar.bz2 flashrom-2b72cdb4f44fa3828a7cac09f288d94e9ce12ecd.zip | |
internal,board_enable: Remove force_boardenable from globals
Make `force_boardenable` stack local to the internal_init()
entry-point. It's life-time should not exceed that of the
internal's init entry function.
Change-Id: I3324681f024003694a5531d9d35bb13d2c583eb0
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/70031
Reviewed-by: Sam McNally <sammc@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/programmer.h | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/include/programmer.h b/include/programmer.h index ad3c5022..9e706d58 100644 --- a/include/programmer.h +++ b/include/programmer.h @@ -224,9 +224,9 @@ int it8705f_write_enable(uint8_t port); uint8_t sio_read(uint16_t port, uint8_t reg); void sio_write(uint16_t port, uint8_t reg, uint8_t data); void sio_mask(uint16_t port, uint8_t reg, uint8_t data, uint8_t mask); -void board_handle_before_superio(void); -void board_handle_before_laptop(void); -int board_flash_enable(const char *vendor, const char *model, const char *cb_vendor, const char *cb_model); +void board_handle_before_superio(bool force_boardenable); +void board_handle_before_laptop(bool force_boardenable); +int board_flash_enable(const char *vendor, const char *model, const char *cb_vendor, const char *cb_model, bool force_boardenable); /* chipset_enable.c */ int chipset_flash_enable(const struct programmer_cfg *cfg); @@ -263,7 +263,6 @@ extern int superio_count; #if CONFIG_INTERNAL == 1 extern int is_laptop; extern bool laptop_ok; -extern bool force_boardenable; extern bool force_boardmismatch; void probe_superio(void); int register_superio(struct superio s); |