diff options
| author | Nico Huber <nico.h@gmx.de> | 2017-11-10 20:18:23 +0100 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2018-01-02 20:14:34 +0000 |
| commit | 1cf407b4f8d56035816efaf936a40553441eca46 (patch) | |
| tree | c8e41e1172aaeb567af161a9763521c53073bdc4 /programmer.h | |
| parent | ed098d62d66d91cf7330a37f9b83e303eb7f56d8 (diff) | |
| download | flashrom-1cf407b4f8d56035816efaf936a40553441eca46.tar.gz flashrom-1cf407b4f8d56035816efaf936a40553441eca46.tar.bz2 flashrom-1cf407b4f8d56035816efaf936a40553441eca46.zip | |
spi_master: Introduce SPI_MASTER_4BA feature flag
Add a feature flag SPI_MASTER_4BA to `struct spi_master` that advertises
programmer-side support for 4-byte addresses in generic commands (and
read/write commands if the master uses the default implementations). Set
it for all masters that handle commands address-agnostic.
Don't prefer native 4BA instructions if the master doesn't support them.
Change-Id: Ife66e3fc49b9716f9c99cad957095b528135ec2c
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/22421
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
Diffstat (limited to 'programmer.h')
| -rw-r--r-- | programmer.h | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/programmer.h b/programmer.h index b390a533..8736449b 100644 --- a/programmer.h +++ b/programmer.h @@ -24,6 +24,8 @@ #ifndef __PROGRAMMER_H__ #define __PROGRAMMER_H__ 1 +#include <stdint.h> + #include "flash.h" /* for chipaddr and flashctx */ enum programmer { @@ -610,8 +612,12 @@ enum spi_controller { #define MAX_DATA_UNSPECIFIED 0 #define MAX_DATA_READ_UNLIMITED 64 * 1024 #define MAX_DATA_WRITE_UNLIMITED 256 + +#define SPI_MASTER_4BA (1U << 0) /**< Can handle 4-byte addresses */ + struct spi_master { enum spi_controller type; + uint32_t features; unsigned int max_data_read; // (Ideally,) maximum data read size in one go (excluding opcode+address). unsigned int max_data_write; // (Ideally,) maximum data write size in one go (excluding opcode+address). int (*command)(struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, @@ -786,4 +792,11 @@ enum SP_PIN { void sp_set_pin(enum SP_PIN pin, int val); int sp_get_pin(enum SP_PIN pin); +/* spi_master feature checks */ +static inline bool spi_master_4ba(const struct flashctx *const flash) +{ + return flash->mst->buses_supported & BUS_SPI && + flash->mst->spi.features & SPI_MASTER_4BA; +} + #endif /* !__PROGRAMMER_H__ */ |