aboutsummaryrefslogtreecommitdiffstats
path: root/spi.c
diff options
context:
space:
mode:
authorEdward O'Callaghan <quasisec@google.com>2023-03-06 11:25:52 +1100
committerEdward O'Callaghan <quasisec@chromium.org>2023-04-06 04:43:29 +0000
commit67b5526d5c46bfc4d70fb288b9227097fc113e30 (patch)
treeabb7854554929194daf7e22bc4cd9a052f72e78b /spi.c
parent3ed016f08faa011736443f3b39bf68187d974781 (diff)
downloadflashrom-67b5526d5c46bfc4d70fb288b9227097fc113e30.tar.gz
flashrom-67b5526d5c46bfc4d70fb288b9227097fc113e30.tar.bz2
flashrom-67b5526d5c46bfc4d70fb288b9227097fc113e30.zip
internal: Move laptop_ok into board_cfg
Due to how internal is structured around chipset_flash_enable() entry we need to prepare a crafted programmer_cfg that contains a board_enable substructure with data derived from the board_enable subsystem. While this is certainly not perfection, it does make clear the relationships between board_enable into chipset_flash_enable and subsequently the overall internal programmer initialisation in a RAII fashion at the type level over closure upon global state that is impossible to reason about. Also flip predicate in report_nonwl_laptop_detected() and return early with the trivial base-case. TEST=`$ sudo ./flashrom -p internal --flash-name`. Change-Id: I459215253845c2af73262943ce91a36464e9eb06 Signed-off-by: Edward O'Callaghan <quasisec@google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/73456 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Sam McNally <sammc@google.com>
Diffstat (limited to 'spi.c')
0 files changed, 0 insertions, 0 deletions