diff options
| author | Daniel Campello <campello@chromium.org> | 2022-03-29 20:47:46 -0600 |
|---|---|---|
| committer | Anastasia Klimchuk <aklm@chromium.org> | 2022-04-06 07:43:55 +0000 |
| commit | 885fb2e82b6e3bf8189f34b5c3c3a67e76262802 (patch) | |
| tree | e37f8788c731fb3dafd444692a9d3d24400ddc79 /tests/lifecycle.c | |
| parent | 9454336970806b9b869ae1ee2515280051e60780 (diff) | |
| download | flashrom-885fb2e82b6e3bf8189f34b5c3c3a67e76262802.tar.gz flashrom-885fb2e82b6e3bf8189f34b5c3c3a67e76262802.tar.bz2 flashrom-885fb2e82b6e3bf8189f34b5c3c3a67e76262802.zip | |
tests: assert pathname and flags when calling open()
With this change the wrappers for mock and friends are able to take an
optional io_mock_fallback_open_state struct to assert expected pathnames
and flags whenever an open operation is called.
Based partially on https://review.coreboot.org/c/flashrom/+/62319/5
BUG=b:227404721,b:217629892,b:215255210
TEST=./test_build.sh; FEATURES=test emerge-amd64-generic flashrom
BRANCH=none
Signed-off-by: Daniel Campello <campello@chromium.org>
Co-Author: Edward O'Callaghan <quasisec@google.com>
Change-Id: Ib46ca5b854c8453ec02ae09f3151cd4d25f988eb
Reviewed-on: https://review.coreboot.org/c/flashrom/+/63227
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Diffstat (limited to 'tests/lifecycle.c')
| -rw-r--r-- | tests/lifecycle.c | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/tests/lifecycle.c b/tests/lifecycle.c index c37f3b99..5566b3bc 100644 --- a/tests/lifecycle.c +++ b/tests/lifecycle.c @@ -370,13 +370,6 @@ void linux_spi_probe_lifecycle_test_success(void **state) #endif } -static int realtek_mst_open(void *state, const char *pathname, int flags) -{ - assert_string_equal(pathname, "/dev/i2c-254"); - assert_int_equal(flags & O_RDWR, O_RDWR); - return MOCK_FD; -} - static int realtek_mst_ioctl(void *state, int fd, unsigned long request, va_list args) { assert_int_equal(fd, MOCK_FD); @@ -406,11 +399,16 @@ static int realtek_mst_write(void *state, int fd, const void *buf, size_t sz) void realtek_mst_basic_lifecycle_test_success(void **state) { #if CONFIG_REALTEK_MST_I2C_SPI == 1 + static struct io_mock_fallback_open_state realtek_mst_fallback_open_state = { + .noc = 0, + .paths = { "/dev/i2c-254", NULL }, + .flags = { O_RDWR }, + }; const struct io_mock realtek_mst_io = { - .open = realtek_mst_open, .ioctl = realtek_mst_ioctl, .read = realtek_mst_read, .write = realtek_mst_write, + .fallback_open_state = &realtek_mst_fallback_open_state, }; io_mock_register(&realtek_mst_io); |