diff options
| author | Nico Huber <nico.huber@secunet.com> | 2017-03-17 17:22:53 +0100 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2017-04-25 18:53:50 +0200 |
| commit | 0ea99f57c9d8fe28600cd08f653c10e5c0c0dd3f (patch) | |
| tree | dda8ea443bd14845e927838fa2e27fba61761584 /util/ich_descriptors_tool | |
| parent | b4d8a2a64b72d65e447161179279c108709c0ac3 (diff) | |
| download | flashrom-0ea99f57c9d8fe28600cd08f653c10e5c0c0dd3f.tar.gz flashrom-0ea99f57c9d8fe28600cd08f653c10e5c0c0dd3f.tar.bz2 flashrom-0ea99f57c9d8fe28600cd08f653c10e5c0c0dd3f.zip | |
Move register decodes into enable_flash_ich_handle_gcs()
GCS was decoded partly inside, partly outside this function. The
decoding of `top_swap` was off, since passing a `uint8_t` as `bool`
doesn't magically check bit0 only.
While we are at it, rename this void function to enable_flash_ich_
report_gcs() as it's not doing anything. Beside debug output it
doesn't have any side effects.
Change-Id: I40addec98cb6840763adad30f9d0e27dadce6d1e
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/18882
Tested-by: build bot (Jenkins)
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Youness Alaoui <snifikino@gmail.com>
Diffstat (limited to 'util/ich_descriptors_tool')
0 files changed, 0 insertions, 0 deletions