diff options
author | Cong Wang <xiyou.wangcong@gmail.com> | 2019-08-25 05:35:06 -0700 |
---|---|---|
committer | Hauke Mehrtens <hauke@hauke-m.de> | 2019-09-01 18:38:04 +0200 |
commit | 7735cce0c5c306bd9eea20ca2805e4a492c02be9 (patch) | |
tree | 06c260348c079366ba373f1ed94fa55085769126 /target/linux/generic/backport-4.19/380-v5.3-net-sched-Introduce-act_ctinfo-action.patch | |
parent | 02169bd3f8ccfa3076bb4d46e979d2fdcc7d413e (diff) | |
download | upstream-7735cce0c5c306bd9eea20ca2805e4a492c02be9.tar.gz upstream-7735cce0c5c306bd9eea20ca2805e4a492c02be9.tar.bz2 upstream-7735cce0c5c306bd9eea20ca2805e4a492c02be9.zip |
kernel: net_sched: fix a NULL pointer deref in ipt action
The net pointer in struct xt_tgdtor_param is not explicitly
initialized therefore is still NULL when dereferencing it.
So we have to find a way to pass the correct net pointer to
ipt_destroy_target().
The best way I find is just saving the net pointer inside the per
netns struct tcf_idrinfo, which could make this patch smaller.
Fixes: 0c66dc1ea3f0 ("netfilter: conntrack: register hooks in netns when needed by ruleset")
Reported-and-tested-by: Tony Ambardar <itugrok@xxxxxxxxx>
Cc: Jamal Hadi Salim <jhs@xxxxxxxxxxxx>
Cc: Jiri Pirko <jiri@xxxxxxxxxxx>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
[Backport for kernel v4.19 and v4.14]
[Bug Link: https://bugzilla.kernel.org/show_bug.cgi?id=204681]
Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
Diffstat (limited to 'target/linux/generic/backport-4.19/380-v5.3-net-sched-Introduce-act_ctinfo-action.patch')
-rw-r--r-- | target/linux/generic/backport-4.19/380-v5.3-net-sched-Introduce-act_ctinfo-action.patch | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/target/linux/generic/backport-4.19/380-v5.3-net-sched-Introduce-act_ctinfo-action.patch b/target/linux/generic/backport-4.19/380-v5.3-net-sched-Introduce-act_ctinfo-action.patch index d0047435fd..909c68e1b5 100644 --- a/target/linux/generic/backport-4.19/380-v5.3-net-sched-Introduce-act_ctinfo-action.patch +++ b/target/linux/generic/backport-4.19/380-v5.3-net-sched-Introduce-act_ctinfo-action.patch @@ -555,7 +555,7 @@ Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk> +{ + struct tc_action_net *tn = net_generic(net, ctinfo_net_id); + -+ return tc_action_net_init(tn, &act_ctinfo_ops); ++ return tc_action_net_init(net, tn, &act_ctinfo_ops); +} + +static void __net_exit ctinfo_exit_net(struct list_head *net_list) |