diff options
| author | Thibaut VARENE <hacks@slashdirt.org> | 2017-09-12 23:22:37 +0200 |
|---|---|---|
| committer | Mathias Kresin <dev@kresin.me> | 2017-09-13 08:07:54 +0200 |
| commit | eff3549c5883a9abc5dbff00c084cabbcfdf4437 (patch) | |
| tree | 4de1960519ea37204b73f45aa9c97de4361dd45c /target/linux/generic/files/drivers/net/phy/ar8216.h | |
| parent | fd84ecda7d3bfebb4237110b8efe2ab2713ea8e1 (diff) | |
| download | upstream-eff3549c5883a9abc5dbff00c084cabbcfdf4437.tar.gz upstream-eff3549c5883a9abc5dbff00c084cabbcfdf4437.tar.bz2 upstream-eff3549c5883a9abc5dbff00c084cabbcfdf4437.zip | |
generic: drop support for get_port_stats() on ar8xxx
The implementation is not efficient on ar8xxx switches. It triggers high
CPU load and degrades device performance.
The high CPU load has been traced down to the ar8xxx_reg_wait() call in
ar8xxx_mib_op(), which has to usleep_range() till the MIB busy flag set
by the request to update the MIB counter is cleared.
This commit removes the get_port_stats() code introduced in 4d8a66d and
leaves a note for future hacker's beware.
Fixes: FS#1004
Signed-off-by: Thibaut VARENE <hacks@slashdirt.org>
Diffstat (limited to 'target/linux/generic/files/drivers/net/phy/ar8216.h')
| -rw-r--r-- | target/linux/generic/files/drivers/net/phy/ar8216.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/target/linux/generic/files/drivers/net/phy/ar8216.h b/target/linux/generic/files/drivers/net/phy/ar8216.h index 321eeb7923..d9508b9ff8 100644 --- a/target/linux/generic/files/drivers/net/phy/ar8216.h +++ b/target/linux/generic/files/drivers/net/phy/ar8216.h @@ -566,9 +566,6 @@ ar8xxx_sw_set_flush_port_arl_table(struct switch_dev *dev, const struct switch_attr *attr, struct switch_val *val); int -ar8xxx_sw_get_port_stats(struct switch_dev *dev, int port, - struct switch_port_stats *stats); -int ar8216_wait_bit(struct ar8xxx_priv *priv, int reg, u32 mask, u32 val); static inline struct ar8xxx_priv * |