aboutsummaryrefslogtreecommitdiffstats
path: root/target/linux/apm821xx
Commit message (Collapse)AuthorAgeFilesLines
* kernel: clean up XATTR config symbolsPaul Spooren2020-10-091-1/+0
| | | | | | | | | | | | | Extended attributes are required for overlayfs and have hence been long ago enabled for jffs2, but should be enabled unconditionally for all other filesystems which may potentially serve as overlayfs' upper directory. Previously it was inconsistently added in multiple targets. Add symbols to generic kernel config and remove all *_XATTR symbols from target configs. Signed-off-by: Paul Spooren <mail@aparcar.org> [keep things as they are for squashfs, improve commit message] Signed-off-by: Daniel Golle <daniel@makrotopia.org>
* treewide: remove empty default casesAdrian Schmutzler2020-09-174-9/+0
| | | | | | There is no apparent reason to have an empty default case. Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
* apm821xx: provide legacy interrupts for PCIe in DTChristian Lamparter2020-09-055-0/+9
| | | | | | | | | | | | | | | | | | | | | | Devices with PCIe-Switches like the WNDR4700, MR24 and WNDAP660 need to have the interrupts property specified in the device-tree for the legacy pci interrupt signaling method to work. If the proper interrupt value is not specified, the default INTA IRQ 12 is taken for all devices. This is especially bad, if the device is setup to use INTC, because these interrupts will not be serviced. Russell Senior reported his experience on the MR24: "The symptom is client devices can't see the beacons. Wifi ifaces appear, can scan and hear other networks, but clients can't see the MR24's SSIDs." (The interrupts-property on the WNDAP620 was optional since it uses INTA by default. Likewise the MX60W is in the same category) Reported-by: Russell Senior <russell@personaltelco.net> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* apm821xx: fix typos in .dts filesChristian Lamparter2020-08-291-2/+2
| | | | | | | This patch fixes various typos or tab-vs-space issues in the APM821XX device targets Device-Tree source files. Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* apm821xx: use SPDX-License-identifiersChristian Lamparter2020-08-298-50/+8
| | | | | | | Please note that the DTS are based on really old .DTS from vendors themselves. Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* apm821xx: apm821xx.dtsi fix comment stylesChristian Lamparter2020-08-291-2/+4
| | | | Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* apm821xx: MX60W: enumerate PCIe in device-treeChristian Lamparter2020-08-291-0/+19
| | | | | | | This patch adds the pcie-switch and bridge configuration for the Meraki MX60W. Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* apm821xx: WNDR4700: delete wndr4700 board fileChristian Lamparter2020-08-295-115/+1
| | | | | | | Thanks to the PCIE OF enumeration patch, this is technically no longer needed. Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* apm821xx: MR24: enumerate PCIe in device-treeChristian Lamparter2020-08-291-0/+51
| | | | | | | This patch adds the pcie-switch and bridge configuration for the Meraki MR24. Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* apm821xx: add missing cells-values for IIC1Christian Lamparter2020-08-291-0/+2
| | | | | | These are copied over from the IIC0. Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* apm821xx: DTB: fix warnings related to sata-port warningsChristian Lamparter2020-08-291-0/+4
| | | | | | | | | This patch silences the following warnings: >netgear-wndr4700.dts:168.3-13:Warning (reg_format): /plb/sata@bffd1800/sata-port@0:reg:property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) >netgear-wndr4700.dts:167.26-170.4: Warning (avoid_default_addr_size):/plb/sata@bffd1800/sata-port@0: Relying on default #address-cells value >netgear-wndr4700.dts:167.26-170.4: Warning (avoid_default_addr_size):/plb/sata@bffd1800/sata-port@0: Relying on default #size-cells value Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* apm821xx: WNDAP6x0: enumerate PCIe in device-treeChristian Lamparter2020-08-292-0/+75
| | | | | | | This patch adds the pcie-switch and bridge configuration of the WNDAP620 and WNDAP660. Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* apm821xx: WNDR4700: enumerate PCIe in device-treeChristian Lamparter2020-08-294-34/+106
| | | | | | | | | | This patch adds the pcie-switch and bridge configuration of the WNDR4700. This allows to get rid of the legacy firmware monikers and drop the usbport LED declaration. Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* treewide: use wpad-basic-wolfssl as defaultPetr Štetiar2020-08-203-3/+3
| | | | | | | | | | | | | | | In order to support SAE/WPA3-Personal in default images. Replace almost all occurencies of wpad-basic and wpad-mini with wpad-basic-wolfssl for consistency. Keep out ar71xx from the list as it won't be in the next release and would only make backports harder. Build-tested (build-bot settings): ath79: generic, ramips: mt7620/mt76x8/rt305x, lantiq: xrx200/xway, sunxi: a53 Signed-off-by: Petr Štetiar <ynezz@true.cz> [rebase, extend commit message] Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
* kernel: bump 5.4 to 5.4.58John Audia2020-08-182-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR is a blend of several kernel bumps authored by ldir taken from his staging tree w/ some further adjustments made by me and update_kernel.sh Summary: Deleted upstreamed patches: generic: 742-v5.5-net-sfp-add-support-for-module-quirks.patch 743-v5.5-net-sfp-add-some-quirks-for-GPON-modules.patch bcm63xx: 022-v5.8-mtd-rawnand-brcmnand-correctly-verify-erased-pages.patch 024-v5.8-mtd-rawnand-brcmnand-fix-CS0-layout.patch mediatek: 0402-net-ethernet-mtk_eth_soc-Always-call-mtk_gmac0_rgmii.patch Deleted patches applied differently upstream: generic: 641-sch_cake-fix-IP-protocol-handling-in-the-presence-of.patch Manually merged patches: generic: 395-v5.8-net-sch_cake-Take-advantage-of-skb-hash-where-appropriate.patch bcm27xx: 950-0132-lan78xx-Debounce-link-events-to-minimize-poll-storm.patch layerscape: 701-net-0231-enetc-Use-DT-protocol-information-to-set-up-the-port.patch Build system: x86_64 Build-tested: ath79/generic, bcm27xx/bcm2708, bcm27xx/bcm2711, imx6, mvebu/cortexa9, sunxi/a53 Run-tested: Netgear R7800 (ipq806x) No dmesg regressions, everything functional Signed-off-by: John Audia <graysky@archlinux.us> Tested-By: Lucian Cristian <Lucian.cristian@gmail.com> [mvebu] Tested-By: Curtis Deptuck <curtdept@me.com> [x86/64] [do not remove 395-v5.8-net-sch_cake-Take-advantage-... patch, adjust and refresh patches, adjust commit message] Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> Tested-By: John Audia <graysky@archlinux.us> [ipq806x]
* apm821xx: tidy up 10-fix-wifi-macAdrian Schmutzler2020-08-171-3/+3
| | | | | | | | | This applies some cosmetic style fixes: - remove useless echo - remove double equal sign (specific to bash) - add quotes for -n check Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
* kernel: Update kernel 4.19 to version 4.19.138Hauke Mehrtens2020-08-101-3/+3
| | | | | | Compile and run tested on lantiq/xrx200 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
* kernel: unify CONFIG_GPIO_SYSFS in kernel configsFelix Fietkau2020-08-062-2/+0
| | | | | | Enable it for all platforms Signed-off-by: Felix Fietkau <nbd@nbd.name>
* target: replace remaining occurrences of ifconfig with ipAdrian Schmutzler2020-08-031-1/+1
| | | | | | | | | | | ifconfig is effectively deprecated for quite some time now. Let's replace the remaining occurrences for our target setup by the corresponding ip commands now. Note that this does not touch ar71xx, as it will be dropped anyway, and changing it would only make backports harder. Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
* apm821xx: disable WNDR4700 5.4 imageChristian Lamparter2020-07-311-0/+1
| | | | | | | | | | | | | | | The compressed image that the buildbots are building is too large for the netgear uboot and it crashes and soft-bricks the device. | Uncompressing Kernel Image ... | LZMA: uncompress or overwrite error 1 - must RESET board to recover The whole target likely needs to be switched zImage which is a major hassle due to powerpc's legacy bootwrapper setup as compared to ARM. So for now, disable the device. Reported-by: Wiktor Stasiak (FS#3258) Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* apm821xx: derive DEVICE_DTS from device nameAdrian Schmutzler2020-07-213-6/+1
| | | | | | | | | | | The DEVICE_DTS variable always matches the device definition name, just with "_" replaced by "-". Thus, create a DEVICE_DTS definition in Device/Default and drop all the individual statements. If necessary in the future, local DEVICE_DTS will still overwrite that default. Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
* kernel: Update kernel 5.4 to version 5.4.50Hauke Mehrtens2020-07-041-1/+1
| | | | | | | Run tested: ath79, ipq40xx Build tested: ath79, ipq40xx Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
* kernel: Update kernel 4.19 to version 4.19.131Hauke Mehrtens2020-07-041-1/+1
| | | | | | | | | | | | | Fixes: - CVE-2020-10757 The "mtd: rawnand: Pass a nand_chip object to nand_release()" commit was backported which needed some adaptations to other code. Run tested: ath79 Build tested: ath79 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
* treewide: drop shebang from non-executable target filesAdrian Schmutzler2020-06-164-8/+0
| | | | | | | | | | | | | | This drops the shebang from all target files for /lib and /etc/uci-defaults folders, as these are sourced and the shebang is useless. While at it, fix the executable flag on a few of these files. This does not touch ar71xx, as this target is just used for backporting now and applying cosmetic changes would just complicate things. Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
* apm821xx: move device definitions to subfilesAdrian Schmutzler2020-06-113-158/+152
| | | | | | | | | | | | With several subtargets, the image/Makefile becomes crowded after a while. Many targets have moved their device definitions to $subtarget.mk files to have them more organized, let's do this here as well. While at it, also move subtarget-specific build recipes. Cc: Christian Lamparter <chunkeey@gmail.com> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> Acked-by: Christian Lamparter <chunkeey@gmail.com>
* apm821xx: set DEVICE_TYPE to "nas" for sata subtargetAdrian Schmutzler2020-06-031-0/+1
| | | | | | | | | | | | | | | | Since DEVICE_TYPE cannot be set per device, just set DEVICE_TYPE to "nas" for the entire subtarget, which only contains this single device. Note that while this looks like a cosmetic change in combination with the previous patches, this particular patch actually changes the packages for the device. Suggested-by: Christian Lamparter <chunkeey@gmail.com> Cc: Christian Lamparter <chunkeey@gmail.com> Cc: Sungbo Eo <mans0n@gorani.run> Cc: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
* treewide: drop DEVICE_TYPE when used as device variableAdrian Schmutzler2020-06-031-1/+0
| | | | | | | | | | | | | | | | | | | | | | | DEVICE_TYPE is a target/subtarget variable, and it does not have any effect when set in a device definition. It can only be set in a target's or subtarget's Makefile. Consequently, having it set anyway is misleading, so this drops all cases. This effectively reverts the following commits: 7a1497fd601d ("apm821xx: MBL: set DEVICE_TYPE to NAS") 5b4765c93a1b ("gemini: Classify Raidsonic NAS IB-4220-B as a NAS") cdc6de460bb4 ("gemini: D-Link DNS-313 is a NAS") For the following commit, the variable was set when adding device support: 27b2f0fc0fc5 ("kirkwood: add support for Iomega Storcenter ix2-200") Cc: Christian Lamparter <chunkeey@gmail.com> Cc: Sungbo Eo <mans0n@gorani.run> Cc: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
* kernel: bump 5.4 to 5.4.36Petr Štetiar2020-04-301-1/+1
| | | | | | | | | | | | | | | Refreshed patches, removed upstreamed patch: generic/hack: 551-loop-Better-discard-support-for-block-devices.patch Added generic config symbol `ARM64_ERRATUM_1542419` due to Fixes: f2791551cedb ("arm64: errata: Hide CTR_EL0.DIC on systems affected by Neoverse-N1 #1542419"). Run tested: qemu-x86-64, apalis, nbg6617 Build tested: x86/64, imx6, ipq40xx, sunxi/a53 Signed-off-by: Petr Štetiar <ynezz@true.cz>
* kernel: bump 4.19 to 4.19.115Koen Vandeputte2020-04-162-4/+4
| | | | | | | | | | | | | | | | | | Refreshed all patches. Remove upstreamed: - 600-ipv6-addrconf-call-ipv6_mc_up-for-non-Ethernet-inter.patch - 184-USB-serial-option-add-Wistron-Neweb-D19Q1.patch Fixes: - CVE-2020-8647 - CVE-2020-8648 (potentially) - CVE-2020-8649 Compile-tested on: cns3xxx Runtime-tested on: cns3xxx Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
* apm821xx: use the real default HZ value from upstreamChristian Lamparter2020-04-101-84/+3
| | | | | | | | | | | | | | | | | | | | With the "real HZ" debate out of the way, let's actually use the apm821xx's default upstream config file at arch/powerpc/configs/44x/bluestone_defconfig. From what I can tell, it sets NO_HZ (well, this platform was for NAS, so this is a bit unexpected) and remove any specific HZ_$VALUE symbol. Sadly, Daniel Engberg didn't run any before/after netperf tests, because it would have been such a slam dunk across the boards. In case of the apm821xx the tcp tx/rx performance improved ~14% (from 600Mbps to 700Mps). This now causes the emac to drop frames too, so let's see if this is causes more problems or not. This patch includes a refresh of the configuration too. Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* treewide: Don't diverge from upstream default HZ settings on 4.19Daniel Engberg2020-03-292-2/+0
| | | | | | | | | | | Most targets upstream use 250Hz or even 1000Hz by default while 100Hz is hardcoded in OpenWrt's default config. Use upstream default except for apm821xx which hardsets 1000Hz instead of platform default of 250Hz. Signed-off-by: Daniel Engberg <daniel.engberg.lists@pyret.net> [Apply same changes to 5.4] Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
* kernel: bump 5.4 to 5.4.28Petr Štetiar2020-03-282-5/+5
| | | | | | | | | | | | | | | | | | | | Changelog since 5.4.24 mentions CVE-2019-19769, CVE-2020-8648, CVE-2020-8649 and CVE-2020-8647. Removed upstreamed: generic: 507-v5.6-iio-chemical-sps30-fix-missing-triggered-buffer-depe.patch generic: 600-ipv6-addrconf-call-ipv6_mc_up-for-non-Ethernet-inter.patch bcm27xx: 950-0435-ASoC-pcm512x-Fix-unbalanced-regulator-enable-call-in.patch ipq806x: 701-stmmac-fix-notifier-registration.patch lantiq: 002-pinctrl-falcon-fix-syntax-error.patch octeontx: 0002-net-thunderx-workaround-BGX-TX-Underflow-issue.patch Run tested: apu2, qemu-x86-64, apalis, a64-olinuxino, nbg6617 Build tested: sunxi/a53, imx6, x86/64, ipq40xx Tested-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk> [apu2] Signed-off-by: Petr Štetiar <ynezz@true.cz>
* apm821xx: switch to 5.4 kernelChristian Lamparter2020-03-221-2/+1
| | | | | | This patch switches the APM821XX target to the linux kernel 5.4 variant. Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* apm821xx: wndr4700: add preliminary drivetemp sensorChristian Lamparter2020-03-222-2/+25
| | | | | | | | | | | | | | | | | | This patch prepares the WNDR4700 to use the HDD sensor for the thermal zone. While the kernel's thermal.txt device-tree binding documentation files talks about supporting multiple sensors for a zone. This sadly is NOT the case. Even the most current upstream kernels (5.6-rc) supports just >one< sensor per zone: (driver/base/of-thermal.c:886) | * REVIST: for now, the thermal framework supports only | * one sensor per thermal zone. Thus, we are considering | * only the first two values as slope and offset. I do hope that this warning will prevent others wasteing time on trying to figure out why their multi-sensor thermal-zones definitions are not working as specified. Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* apm821xx: add drivetemp sensor for the WD MyBook SeriesChristian Lamparter2020-03-222-1/+11
| | | | | | | | | This patch adds the hwmon-drivetemp to the device. It also adds device-tree bindings. This can be useful to automate external fans which can be controlled for example by either an unused sata-port or by the usb-power regulator. Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* treewide: omit IMAGE_SIZE argument from check-sizeSungbo Eo2020-03-211-1/+1
| | | | | | | | | Now that check-size uses IMAGE_SIZE by default, we can skip the argument from image recipes to reduce redundancy. Signed-off-by: Sungbo Eo <mans0n@gorani.run> [do not touch ar71xx] Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
* treewide: remove maintainer variable from targetsPetr Štetiar2020-03-161-2/+0
| | | | | | | | | | | | | There is no such role as target maintainer anymore, one should always send corresponding changes for the review and anyone from the commiters is allowed to merge them or eventually use the hand break and NACK them. Lets make it clear, that it is solely a community doing the maintenance tasks. Signed-off-by: Petr Štetiar <ynezz@true.cz> Acked-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> Acked-by: Piotr Dymacz <pepe2k@gmail.com>
* apm821xx: 4.14: remove kernel config and patchesChristian Lamparter2020-03-1460-8847/+0
| | | | | | | | This patch removes the 4.14 kernel support from the apm821xx target. The 4.19 kernel has been available and stable for a while and the 5.4 kernel support has been tested successfully on real hardware as well. Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* build: image: move IMAGE_SIZE to image.mkSungbo Eo2020-03-111-1/+1
| | | | | | | | | | IMAGE_SIZE is widely used in many targets. Declare it in the default template to clean up redundant code. This also prevents deriving IMAGE_SIZE unintentionally from the previously defined device. While at it, remove duplicate KERNEL_SIZE declaration. Signed-off-by: Sungbo Eo <mans0n@gorani.run>
* kernel: 5.4: move some kconfig options to genericYousong Zhou2020-03-101-6/+0
| | | | | | | | | | | CONFIG_64BIT_TIME=y CONFIG_KASAN_STACK=1 CONFIG_UBSAN_ALIGNMENT=y CONFIG_UNIX_SCM=y CONFIG_DMA_DECLARE_COHERENT=y CONFIG_OF_RESERVED_MEM=y Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
* kernel: bump 5.4 to 5.4.24Koen Vandeputte2020-03-092-7/+7
| | | | | | | | | Refreshed all patches. Compile-tested on: imx6 Runtime-tested on: imx6 Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
* kernel: bump 4.19 to 4.19.108Koen Vandeputte2020-03-092-5/+5
| | | | | | | | | Refreshed all patches. Compile-tested on: cns3xxx Runtime-tested on: cns3xxx Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
* kernel: bump 4.14 to 4.14.172Koen Vandeputte2020-03-092-4/+4
| | | | | | | | | Refreshed all patches. Compile-tested on: cns3xxx Runtime-tested on: cns3xxx Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
* treewide: move commonly disabled symbols to generic configDavid Bauer2020-03-011-4/+0
| | | | | | | Move new commonly disabled kernel 5.4 symbols to the generic kernel configuration. Signed-off-by: David Bauer <mail@david-bauer.net>
* apm821xx: remove gpio-interrupt cruftChristian Lamparter2020-02-291-6/+0
| | | | | | | | | | | This hunk became obsolete the moment when our gpio-button-hotplug learned how to deal with interrupt-supported gpio buttons. The gpio driver never supported interrupt handling, so these properties never served any use (outside of a enhanced ppc4xx-gpio driver that was dropped). Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* apm821xx: 5.4: add important NAND symbolsChristian Lamparter2020-02-281-0/+3
| | | | | | | | This patch adds important NAND config symbols. These are necessary as otherwise the devices won't find the rootfs on the NAND chips. Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* ath79: add support for kernel 5.4David Bauer2020-02-2810-53/+34
| | | | | | | | | | | | | | | Signed-off-by: David Bauer <mail@david-bauer.net> [refreshed] Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com> * Sync the patches with the changes done for kernel 4.19 * Use KERNEL_TESTING_PATCHVER * Refresh the configuration * Fix multiple compile bugs in the patches * Only add own ag71xx files for kernel 4.19 and use upstream version for 5.4. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
* apm821xx: add linux kernel 5.4 testing supportChristian Lamparter2020-02-2813-0/+2102
| | | | | | | This patch adds support for the linux kernel version 5.4 as an optional testing kernel. Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
* kernel: bump 4.19 to 4.19.101Koen Vandeputte2020-02-041-39/+0
| | | | | | | | | | | | | | | | | | Refreshed all patches. Fixes: - CVE-2019-14896 - CVE-2019-14897 Remove upstreamed: - 023-0007-crypto-crypto4xx-Fix-wrong-ppc4xx_trng_probe-ppc4xx_.patch - 950-0202-staging-bcm2835-camera-fix-module-autoloading.patch - 001-4.22-01-MIPS-BCM63XX-drop-unused-and-broken-DSP-platform-dev.patch Compile-tested on: cns3xxx Runtime-tested on: cns3xxx Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
* kernel: bump 4.14 to 4.14.169Koen Vandeputte2020-02-041-39/+0
| | | | | | | | | | | | | | | | | Refreshed all patches. Fixes: - CVE-2019-14896 - CVE-2019-14897 Remove upstreamed: - 023-0007-crypto-crypto4xx-Fix-wrong-ppc4xx_trng_probe-ppc4xx_.patch - 001-4.22-01-MIPS-BCM63XX-drop-unused-and-broken-DSP-platform-dev.patch Compile-tested on: cns3xxx Runtime-tested on: cns3xxx Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>