openwrt/upstream - upstream openwrt

	Commit message (Collapse)	Author	Age	Files	Lines
*	tools/automake: Revert "Do not use $(V) - force AM_V=1"	Fredrik Olofsson	2019-11-06	1	-13/+0
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This reverts commit 43365ca66253 ("Do not use $(V) - force AM_V=1") as it breaks verbose output in automake packages, deviating from the upstream and expected behaviour. As you can see, neither make command outputs the expected verbose compile command lines: ``` $ make package/mtd-utils/{clean,compile} V=sc ... CCLD lsmtd CC nand-utils/nanddump.o CCLD nanddump ... ``` ``` $ make -C build_dir/target/mtd-utils-2.1.1 clean ... $ make -C build_dir/target/mtd-utils-2.1.1 V=1 ... CC lib/libmtd.o CC lib/libfec.o CC lib/common.o CC lib/libcrc32.o ``` The original reason for this commit was some packages failing to build if V is set to something other than 0 or 1. See the discussion in PR https://github.com/openwrt/openwrt/pull/2481 for how to fix this in the package Makefile. Ref: PR#2481 Acked-by: Mirko Vogt <mirko-openwrt@nanl.de> Signed-off-by: Fredrik Olofsson <fredrik.olofsson@anyfinetworks.com> [commit title/description facelift] Signed-off-by: Petr Štetiar <ynezz@true.cz>
*	Do not use $(V) - force AM_V=1	Mirko Vogt	2015-03-12	1	-0/+13
	Projects using silent-rules might otherwise fail to compile. This is due to the following resulting Makefile code: AM_V_P = $(am__v_P_$(V)) am__v_P_ = $(am__v_P_$(AM_DEFAULT_VERBOSITY)) am__v_P_0 = false am__v_P_1 = : Automake directly uses $(V) for variable name expansion which fails if $(V) is set to sth. else other than '0' or '1'. This patch forces automake to not take $(V) into account but to always use the default config for verbosity. A better approach would be to actually take $(V) into account, however not just pass it through (AM_V='$(V)') but set AM_V to 0 if $V=0 / unset and to 1 otherwise. This plan however is foiled due to my frustration about automake as well as my lack of m4 skills. automake bug report: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20077 Signed-off-by: Mirko Vogt <mirko@openwrt.org> SVN-Revision: 44684