blob: 4774fd23261c5ae5a9e838f8c008c8c6281df807 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
|
From 38e906c77467bf83ec130bea6859b46ea1e0d4b8 Mon Sep 17 00:00:00 2001
From: Naushir Patuck <naush@raspberrypi.com>
Date: Thu, 30 Jan 2020 12:35:44 +0000
Subject: [PATCH] staging: vc04_services: Fix vcsm overflow bug when
counting transactions
The response block and local state were using u16 and u32 respectively
to represent transaction id. When the former would wrap, there is a
mismatch and subsequent transactions will be marked as failures.
Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
---
drivers/staging/vc04_services/vc-sm-cma/vc_sm_cma_vchi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/vc04_services/vc-sm-cma/vc_sm_cma_vchi.c
+++ b/drivers/staging/vc04_services/vc-sm-cma/vc_sm_cma_vchi.c
@@ -34,7 +34,7 @@ struct sm_cmd_rsp_blk {
/* To be signaled when the response is there */
struct completion cmplt;
- u16 id;
+ u32 id;
u16 length;
u8 msg[VC_SM_MAX_MSG_LEN];
|
