1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
|
From e9c0434a55a0ddf28b1e7868890eb7557b2c28f9 Mon Sep 17 00:00:00 2001
From: Razvan Stefanescu <razvan.stefanescu@nxp.com>
Date: Thu, 17 Aug 2017 19:47:22 +0300
Subject: [PATCH] staging: dpaa2-evb: Update MTU update procedure
Set limits on the MTU to accommodate netdevice update. There is no need to
check the limits before setting the new value.
Signed-off-by: Razvan Stefanescu <razvan.stefanescu@nxp.com>
---
drivers/staging/fsl-dpaa2/evb/evb.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
--- a/drivers/staging/fsl-dpaa2/evb/evb.c
+++ b/drivers/staging/fsl-dpaa2/evb/evb.c
@@ -53,9 +53,9 @@ static const char evb_drv_version[] = "0
#define DPDMUX_MAX_IRQ_NUM 2
/* MAX FRAME LENGTH (currently 10k) */
-#define EVB_MAX_FRAME_LENGTH (10 * 1024)
-/* MIN FRAME LENGTH (64 bytes + 4 bytes CRC) */
-#define EVB_MIN_FRAME_LENGTH 68
+#define EVB_MAX_FRAME_LENGTH (10 * 1024)
+#define EVB_MAX_MTU (EVB_MAX_FRAME_LENGTH - VLAN_ETH_HLEN)
+#define EVB_MIN_MTU 68
struct evb_port_priv {
struct net_device *netdev;
@@ -457,16 +457,10 @@ static int evb_change_mtu(struct net_dev
if (port_priv->port_index > 0)
return -EPERM;
- if (mtu < EVB_MIN_FRAME_LENGTH || mtu > EVB_MAX_FRAME_LENGTH) {
- netdev_err(netdev, "Invalid MTU %d. Valid range is: %d..%d\n",
- mtu, EVB_MIN_FRAME_LENGTH, EVB_MAX_FRAME_LENGTH);
- return -EINVAL;
- }
-
err = dpdmux_set_max_frame_length(evb_priv->mc_io,
0,
evb_priv->mux_handle,
- (uint16_t)mtu);
+ (uint16_t)(mtu + VLAN_ETH_HLEN));
if (unlikely(err)) {
netdev_err(netdev, "dpdmux_ul_set_max_frame_length err %d\n",
@@ -1291,6 +1285,10 @@ static int evb_probe(struct fsl_mc_devic
list_add(&port_priv->list, &priv->port_list);
} else {
+ /* Set MTU limits only on uplink */
+ port_netdev->min_mtu = EVB_MIN_MTU;
+ port_netdev->max_mtu = EVB_MAX_MTU;
+
err = register_netdev(netdev);
if (err < 0) {
|
