diff options
| author | Rafał Miłecki <rafal@milecki.pl> | 2018-12-25 18:46:44 +0100 |
|---|---|---|
| committer | Rafał Miłecki <rafal@milecki.pl> | 2018-12-28 23:09:38 +0100 |
| commit | ae622c93b3b4df7a55ef2cdb9986eec2bf42159b (patch) | |
| tree | 91a41047e9e26ca08fba366c06d82918e7934c2c /package/network/services/samba36/Makefile | |
| parent | 3c899aaf11580353bc9ab1c3d9c3f638db80ba7c (diff) | |
| download | upstream-ae622c93b3b4df7a55ef2cdb9986eec2bf42159b.tar.gz upstream-ae622c93b3b4df7a55ef2cdb9986eec2bf42159b.tar.bz2 upstream-ae622c93b3b4df7a55ef2cdb9986eec2bf42159b.zip | |
Revert "samba36: add hotplug support"
This reverts commit fd569e5e9d0a46ea957cb253e97a4b3ea8c2c540.
After an extra review & discussion few concerns were raised regarding
that feature:
1) It reacts to hotplug.d "block" events instead of more accurate (but
currently unavailable) "mount" events.
2) It requires *something* to mount block device before samba hotplug.d
gets fired. Otherwise samba_add_section() will just return.
3) It doesn't reload Samba which some users may expect
4) It operates on /etc/ which is not a right place for autogenerated
ephemeral config.
5) It doesn't include any cleanup for non-existing shares.
Cc: Rosy Song <rosysong@rosinson.com>
Cc: Jo-Philipp Wich <jo@mein.io>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Diffstat (limited to 'package/network/services/samba36/Makefile')
| -rw-r--r-- | package/network/services/samba36/Makefile | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/package/network/services/samba36/Makefile b/package/network/services/samba36/Makefile index d38e942074..b63c2eaad3 100644 --- a/package/network/services/samba36/Makefile +++ b/package/network/services/samba36/Makefile @@ -43,12 +43,6 @@ define Package/samba36-server DEPENDS:=+USE_GLIBC:librt $(ICONV_DEPENDS) endef -define Package/samba36-hotplug - $(call Package/samba/Default) - TITLE+= hotplug - DEPENDS:=+block-mount -endef - define Package/samba36-client $(call Package/samba/Default) TITLE+= client @@ -167,13 +161,6 @@ define Package/samba36-server/install $(LN) samba_multicall $(1)/usr/sbin/smbpasswd endef -define Package/samba36-hotplug/install - $(INSTALL_DIR) $(1)/lib/samba - $(INSTALL_CONF) ./files/lib/samba.sh $(1)/lib/samba/samba.sh - $(INSTALL_DIR) $(1)/etc/hotplug.d/block - $(INSTALL_CONF) ./files/samba.hotplug $(1)/etc/hotplug.d/block/60-samba -endef - define Package/samba36-client/install $(INSTALL_DIR) $(1)/usr/sbin $(INSTALL_BIN) $(PKG_BUILD_BIN)/smbclient $(1)/usr/sbin @@ -187,6 +174,5 @@ endef $(eval $(call BuildPackage,samba36-client)) $(eval $(call BuildPackage,samba36-server)) -$(eval $(call BuildPackage,samba36-hotplug)) $(eval $(call BuildPackage,samba36-net)) |